Review main Merged

63414[BUGFIX] Fix Exception caused by empty staticPageArguments

Manuel Munz CR +2 V +2 Easy +2 −2 updated 02/27/20, 12:51

Commit message

When 'Index Records immediately when saved?' is enabled in indexing
configurations for records, then on saving the record the
string 'null' is used for this indexingconfiguration and passed to
SearchController::preparePageLink(), which expects an array and
therefore throws an exception.

This commit fixes this by checking if
$this->conf['staticPageArguments'] is an array and only then json_decode
that, else it sets the value to null.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 56

  1. Manuel Munz uploaded patch set 1 02/25/20, 17:37

  2. Manuel Munz wrote 02/25/20, 17:48

    Topic set to indexed_search
  3. TYPO3com voted on patch set 1 V +1 02/25/20, 17:50 Completed build in 13m 09s on Tue, 25 Feb, 05:50 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-702

  4. Benni Mack voted on patch set 1 V +1 CR +1 02/27/20, 11:20

  5. Georg Ringer voted on patch set 1 V +2 CR +2 02/27/20, 12:51

  6. Georg Ringer merged patch set 2 02/27/20, 12:51