Review main Merged

6343[TASK] Improve debugTrail() to better handle includes

Markus Klein CR +2 V +2 Easy +6 −1 updated 06/03/13, 20:49

Commit message

The deprecation log lacks specific and necessary information about
include and require calls, which makes it hard to actually follow
a stack trace.

Add special treatment of this sort of functions and display additional
path information.

Review

  • Code review CR +2
    • Tolleiv Nietsch +2
    • Wouter Wolters +1
    • Steffen Gebert +1
  • Verified V +2
    • Tolleiv Nietsch +2
    • Steffen Gebert +1

Issues 1

Files 1

Review log 22

  1. Markus Klein uploaded patch set 2 01/14/12, 11:25

  2. Stefan Neufeind commented on patch set 3 01/14/12, 11:25

    Looks good to me, but someone else must approve trivial but helpful
  3. Markus Klein uploaded patch set 3 01/14/12, 11:25

  4. Stefan Neufeind commented on patch set 4 01/14/12, 11:25

    Looks good to me, but someone else must approve
  5. Markus Klein commented on patch set 4 01/14/12, 11:25

    Is anybody willing to vote for this one?
  6. Oliver Hader uploaded patch set 4 01/14/12, 11:25

  7. Oliver Hader commented on patch set 4 01/14/12, 11:25

    Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:0, R:1 from Georg Ringer <mail@ringerge.org> V:0, R:1 from Simon Schaufelberger <simonschaufi@googlemail.com>
  8. Georg Ringer commented on patch set 2 01/14/12, 11:25

    I would prefer that you didn't submit this

    class.t3lib_utility_debug.php:228

    wanna use a better naming? CGL imo also camelcase?

    class.t3lib_utility_debug.php:232

    2 ; at the end?
  9. Georg Ringer commented on patch set 3 01/14/12, 11:25

    Looks good to me, but someone else must approve
  10. Georg Ringer commented on patch set 4 01/14/12, 11:25

    Verified; Looks good to me, but someone else must approve
  11. Steffen Gebert commented on patch set 4 01/14/12, 11:25

    (1 inline comment)

    class.t3lib_utility_debug.php:229

    I would prefer using in_array() here..
  12. Tolleiv Nietsch commented on patch set 5 V 0 01/14/12, 11:25

    by team member; Looks good to me, approved
  13. Steffen Gebert commented on patch set 5 01/14/12, 11:25

    Verified; Looks good to me, but someone else must approve
  14. Steffen Gebert uploaded patch set 5 01/14/12, 11:25

  15. Simon Schaufelberger commented on patch set 3 01/14/12, 11:25

    Looks good to me, but someone else must approve
  16. Mr. Jenkins commented on patch set 1 01/14/12, 11:25

  17. Mr. Jenkins commented on patch set 2 01/14/12, 11:25

  18. Mr. Jenkins commented on patch set 3 01/14/12, 11:25

  19. Mr. Jenkins commented on patch set 4 01/14/12, 11:25

  20. Mr. Jenkins commented on patch set 5 01/14/12, 11:25

  21. Wouter Wolters commented on patch set 5 01/14/12, 11:25

    Looks good to me, but someone else must approve
  22. Tolleiv Nietsch merged patch set 5 01/14/12, 11:25