6343[TASK] Improve debugTrail() to better handle includes
Commit message
Review
-
Code review CR +2
- Tolleiv Nietsch +2
- Wouter Wolters +1
- Steffen Gebert +1
-
Verified V +2
- Tolleiv Nietsch +2
- Steffen Gebert +1
Issues 1
Files 1
Review log 22
-
Markus Klein uploaded patch set 2 01/14/12, 11:25
-
Stefan Neufeind commented on patch set 3 01/14/12, 11:25
Looks good to me, but someone else must approve trivial but helpful -
Markus Klein uploaded patch set 3 01/14/12, 11:25
-
Stefan Neufeind commented on patch set 4 01/14/12, 11:25
Looks good to me, but someone else must approve -
Markus Klein commented on patch set 4 01/14/12, 11:25
Is anybody willing to vote for this one? -
Oliver Hader uploaded patch set 4 01/14/12, 11:25
-
Oliver Hader commented on patch set 4 01/14/12, 11:25
Looks good to me, but someone else must approve Rebasing to master V:0, R:1 V:0, R:1 from Stefan Neufeind <typo3.neufeind@speedpartner.de> V:0, R:1 from Georg Ringer <mail@ringerge.org> V:0, R:1 from Simon Schaufelberger <simonschaufi@googlemail.com> -
Georg Ringer commented on patch set 2 01/14/12, 11:25
I would prefer that you didn't submit thisclass.t3lib_utility_debug.php:228wanna use a better naming? CGL imo also camelcase?class.t3lib_utility_debug.php:2322 ; at the end? -
Georg Ringer commented on patch set 3 01/14/12, 11:25
Looks good to me, but someone else must approve -
Georg Ringer commented on patch set 4 01/14/12, 11:25
Verified; Looks good to me, but someone else must approve -
Steffen Gebert commented on patch set 4 01/14/12, 11:25
(1 inline comment)class.t3lib_utility_debug.php:229I would prefer using in_array() here.. -
Tolleiv Nietsch commented on patch set 5 V 0 01/14/12, 11:25
by team member; Looks good to me, approved -
Steffen Gebert commented on patch set 5 01/14/12, 11:25
Verified; Looks good to me, but someone else must approve -
Steffen Gebert uploaded patch set 5 01/14/12, 11:25
-
Simon Schaufelberger commented on patch set 3 01/14/12, 11:25
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 01/14/12, 11:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2316/ : SUCCESS -
Mr. Jenkins commented on patch set 2 01/14/12, 11:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2408/ : SUCCESS -
Mr. Jenkins commented on patch set 3 01/14/12, 11:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2411/ : SUCCESS -
Mr. Jenkins commented on patch set 4 01/14/12, 11:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2675/ : SUCCESS -
Mr. Jenkins commented on patch set 5 01/14/12, 11:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/2870/ : SUCCESS -
Wouter Wolters commented on patch set 5 01/14/12, 11:25
Looks good to me, but someone else must approve -
Tolleiv Nietsch merged patch set 5 01/14/12, 11:25