Review 9.5 Merged

63432[BUGFIX] Use brackets to access 1st char in string

Georg Ringer CR +2 V +2 Easy +1 −1 updated 02/26/20, 09:23

Commit message

To stay compatible with PHP 7.4 brackets instead of curly braces must be
used.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Markus Klein +1
    • Daniel Siepmann +1
    • Pascal Rinker +1
    • Tymoteusz Motylewski +1
    • Stefan Froemken +1
    • Christian Eßl +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Markus Klein +1
    • Pascal Rinker +1
    • Stefan Froemken +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1415

  1. Georg Ringer uploaded patch set 1 02/25/20, 20:42

  2. Georg Ringer commented on patch set 1 02/25/20, 20:44

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 02/25/20, 20:59 Completed build in 15m 47s on Tue, 25 Feb, 08:59 PM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-89

  4. Oliver Klee voted on patch set 1 CR +1 02/25/20, 21:02

  5. Tymoteusz Motylewski voted on patch set 1 CR +1 02/25/20, 21:40

  6. Markus Klein voted on patch set 1 V +1 CR +1 02/25/20, 22:28

  7. Daniel Siepmann voted on patch set 1 CR +1 02/26/20, 06:06

  8. Stefan Froemken voted on patch set 1 V +1 CR +1 02/26/20, 07:49

  9. Susi Moog voted on patch set 1 CR +1 02/26/20, 07:54

  10. Oli Bartsch voted on patch set 1 CR +1 02/26/20, 07:56

  11. Oli Bartsch voted on patch set 1 V +1 02/26/20, 08:10

  12. Christian Eßl voted on patch set 1 V +1 CR +1 02/26/20, 08:15

  13. Pascal Rinker voted on patch set 1 V +1 CR +1 02/26/20, 08:42

  14. Georg Ringer voted on patch set 1 V +2 CR +2 02/26/20, 09:22

  15. Georg Ringer merged patch set 2 02/26/20, 09:23