Review main Merged

63433[BUGFIX] Fix adding assets from uncached plugins

Helmut Hummel CR +2 V +2 Easy +9 −2 updated 02/28/20, 06:04

Commit message

AssetCollector is a singleton, but of course does not survive requests.
Since uncached plugins should be able to access asset state from cached TypoScript
or other uncached plugins, we must make sure this state is serialized in the cache
(PageRenderer is serialized) and restored from cache.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Eßl +1
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1113

  1. Helmut Hummel uploaded patch set 1 02/25/20, 22:25

  2. TYPO3com voted on patch set 1 V +1 02/25/20, 22:35 Completed build in 10m 11s on Tue, 25 Feb, 10:35 PM Test Summary: 71995 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-704

  3. Oliver Klee commented on patch set 1 CR -1 02/25/20, 23:35

    Unresolved

    The ticket ID is still missing.
  4. Georg Ringer updated the commit message in patch set 2 02/26/20, 05:11

  5. TYPO3com voted on patch set 2 V +1 02/26/20, 05:21 Completed build in 10m 53s on Wed, 26 Feb, 05:21 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-706

  6. Oli Bartsch voted on patch set 2 CR +1 02/26/20, 05:22

  7. Christian Eßl voted on patch set 2 CR +1 02/26/20, 06:31

  8. Susi Moog voted on patch set 2 CR +1 02/26/20, 07:55

  9. Oliver Klee voted on patch set 2 CR +1 02/26/20, 10:15

  10. Susi Moog voted on patch set 2 V +1 02/26/20, 16:33

  11. Georg Ringer voted on patch set 2 V +2 CR +2 02/26/20, 19:26

  12. Georg Ringer merged patch set 3 02/26/20, 19:26

  13. Susi Moog commented on patch set 3 02/28/20, 06:04

    post -1: the assetCollector is not serializable if media files are added (file objects)