Review 9.5 Merged

63435[BUGFIX] Raise minimum requirement of symfony/http-foundation

Andreas Kienast CR +2 V +2 Easy +5 −5 updated 02/27/20, 11:05

Commit message

This patch raises the minimum requirement of symfony/http-foundation to
v4.2.9 as the required constant `Cookie::SAMESITE_NONE` has been added in
this very version.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2528

Show 23 earlier messages
  1. Andreas Kienast uploaded patch set 1 02/25/20, 23:02

  2. Markus Klein voted on patch set 1 V +1 CR +1 02/25/20, 23:05

  3. TYPO3com voted on patch set 1 V -1 02/25/20, 23:14 Completed build in 12m 37s on Tue, 25 Feb, 11:14 PM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-90

  1. Oliver Klee voted on patch set 1 CR +1 02/25/20, 23:34

  2. Georg Ringer uploaded patch set 2 02/26/20, 05:16

  3. TYPO3com voted on patch set 2 V +1 02/26/20, 05:28 Completed build in 11m 39s on Wed, 26 Feb, 05:28 AM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-91

  4. Daniel Siepmann voted on patch set 2 CR +1 02/26/20, 07:41

  5. Susi Moog voted on patch set 2 CR +1 02/26/20, 07:54

  6. Tobi Kretschmann voted on patch set 2 CR +1 02/26/20, 08:09

  7. Georg Ringer voted on patch set 2 V +1 CR +1 02/26/20, 08:09

  8. Oliver Klee voted on patch set 2 CR +1 02/26/20, 09:36

  9. Susi Moog commented on patch set 2 CR -1 02/26/20, 13:27

    composer.lock:1480

    did you just raise the packaged version of symfony/http-foundation, too? This seems like a mistake.
  10. Andreas Kienast commented on patch set 2 02/26/20, 13:47

    composer.lock:1480 Reply

    I did a "composer require symfony/http-foundation:^4.3 || ^5.0", obviously this was wrong
  11. Oliver Klee voted on patch set 2 CR 0 02/26/20, 14:00

  12. Susi Moog commented on patch set 2 02/26/20, 14:54

    composer.lock:1480 Reply

    I think manually changing it to ^4.3 and then composer update --lock should do the trick.
  13. Markus Klein commented on patch set 2 02/26/20, 14:57

    composer.lock:1480 Reply Unresolved

    What speaks against shipping v5 with the core?
  14. Susi Moog commented on patch set 2 02/26/20, 15:01

    this is a regression fix for 9.5 @Markus - I'd not mix that with a major update of a package.
  15. Markus Klein commented on patch set 2 02/26/20, 15:04

    > Patch Set 2: > > this is a regression fix for 9.5 @Markus - I'd not mix that with a major update of a package. Alright. Fine with me of course.
  16. Benni Mack commented on patch set 2 CR -1 02/26/20, 16:00

    How would this happen? I did research on this back then, but did some more... 1. symfony/http-foundation 4.2 (actually 4.2.9) does contain this very constant already. See https://github.com/symfony/http-foundation/blob/4.2/Cookie.php#L32 and https://github.com/symfony/http-foundation/commit/f9bb07318c806a7dbe246f196b8af941585ad8e7 2. The bundled version (tarball) contains 4.4, which does not need to be modified. The correct change is actually do modify the minimum constraint to ^4.2.9 || ^5.0 and then do a composer update --lock. As this would affect TYPO3 v8 as well, we should do it as well. This is an edge case which ONLY happened in composer mode and somebody typed a `composer update typo3/cms-*" and not "--with-dependencies" and that this person actually would use insecure symfony components in their installation.
  17. Susi Moog commented on patch set 2 02/26/20, 16:49

    > Patch Set 2: Code-Review-1 > > How would this happen? I did research on this back then, but did some more... > > 1. symfony/http-foundation 4.2 (actually 4.2.9) does contain this very constant already. See https://github.com/symfony/http-foundation/blob/4.2/Cookie.php#L32 > and https://github.com/symfony/http-foundation/commit/f9bb07318c806a7dbe246f196b8af941585ad8e7 > > 2. The bundled version (tarball) contains 4.4, which does not need to be modified. > > The correct change is actually do modify the minimum constraint to ^4.2.9 || ^5.0 and then do a composer update --lock. > > As this would affect TYPO3 v8 as well, we should do it as well. > > This is an edge case which ONLY happened in composer mode and somebody typed a `composer update typo3/cms-*" and not "--with-dependencies" and that this person actually would use insecure symfony components in their installation. for completeness sake: or with --prefer-lowest
  18. Andreas Kienast commented on patch set 2 02/26/20, 16:49

    > The correct change is actually do modify the minimum constraint to ^4.2.9 || ^5.0 and then do a composer update --lock. on it > As this would affect TYPO3 v8 as well, we should do it as well. Interestingly, nightlies don't fail for v8.
  19. Andreas Kienast uploaded patch set 3 02/26/20, 16:51

  20. Andreas Kienast commented on patch set 3 02/26/20, 16:55

    v3.4.28 would be fine for 8.7
  21. Oliver Klee voted on patch set 3 CR +1 02/26/20, 16:57

  22. TYPO3com voted on patch set 3 V +1 02/26/20, 17:03 Completed build in 12m 30s on Wed, 26 Feb, 05:03 PM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-96

  23. Susi Moog voted on patch set 3 CR +1 02/27/20, 08:00

  24. Benni Mack voted on patch set 3 V +2 CR +2 02/27/20, 11:05

  25. Benni Mack merged patch set 4 02/27/20, 11:05