63439[TASK] use strict type comparison for isValueSelected
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Daniel Goerz +1
- Susi Moog +1
-
Verified V +2 Done
- Georg Ringer +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 2
Review log 1522
-
TYPO3com uploaded patch set 1 02/26/20, 10:21
-
Mathias Brodala commented on patch set 1 CR -1 02/26/20, 10:24
-
Mathias Brodala commented on patch set 2 02/26/20, 10:25
Published edit on patch set 1. -
TYPO3com voted on patch set 1 V +1 02/26/20, 10:31 Completed build in 10m 16s on Wed, 26 Feb, 10:31 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-714
-
TYPO3com voted on patch set 2 V +1 02/26/20, 10:35 Completed build in 10m 04s on Wed, 26 Feb, 10:35 AM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-715
-
Oliver Klee commented on patch set 2 02/26/20, 13:44
OptionViewHelper.php:75This change seems to be unrelated. -
Mathias Brodala commented on patch set 2 CR -1 02/26/20, 14:01
OptionViewHelper.php:75Reply UnresolvedThat's true, it's just an iteration (heh) of the originally suggested change and should be done separately. -
Mathias Brodala commented on patch set 3 02/26/20, 14:02
Published edit on patch set 2. -
Oliver Klee voted on patch set 3 CR +1 02/26/20, 14:08
-
TYPO3com voted on patch set 3 V -1 02/26/20, 14:12 Completed build in 10m 15s on Wed, 26 Feb, 02:12 PM Test Summary: 71702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-718
-
TYPO3com voted on patch set 3 V +1 02/26/20, 14:25 Completed build in 10m 18s on Wed, 26 Feb, 02:25 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-719
-
Susi Moog voted on patch set 3 CR +1 02/27/20, 13:15
-
Susi Moog commented on patch set 3 CR -1 02/27/20, 13:36
found at least one other bug while testing, will try to write some tests. -
Susi Moog uploaded patch set 4 02/27/20, 13:55
-
TYPO3com voted on patch set 4 V -1 02/27/20, 13:55 Completed build in 21s on Thu, 27 Feb, 01:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-739
-
Susi Moog commented on patch set 4 02/27/20, 13:56
OptionViewHelper.php:48Unresolvedthis now takes care of correct selection when childContent is used as fallback value. -
Susi Moog uploaded patch set 5 02/27/20, 13:57
-
TYPO3com voted on patch set 5 V +1 02/27/20, 14:08 Completed build in 10m 20s on Thu, 27 Feb, 02:08 PM Test Summary: 72045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-740
-
Susi Moog voted on patch set 5 V +1 CR +1 02/27/20, 18:39
-
Daniel Goerz voted on patch set 5 CR +1 02/27/20, 18:55
-
Georg Ringer voted on patch set 5 V +2 CR +2 02/28/20, 08:38
-
Georg Ringer merged patch set 6 02/28/20, 08:38
OptionViewHelper.php:80Unresolved