Review main Merged

63445[TASK] Add meaningful terms in various PHPDocs and comments

Oli Bartsch CR +2 V +2 Easy +15 −15 updated 02/27/20, 14:40

Commit message

To make examples more clear more meaningful terms are now used.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Tymoteusz Motylewski +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Tymoteusz Motylewski +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 912

  1. Oli Bartsch uploaded patch set 1 02/27/20, 12:04

  2. Oli Bartsch updated the commit message in patch set 2 02/27/20, 12:06

  3. TYPO3com voted on patch set 1 V +1 02/27/20, 12:15 Completed build in 11m 17s on Thu, 27 Feb, 12:15 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-732

  4. TYPO3com voted on patch set 2 V +1 02/27/20, 12:20 Completed build in 13m 21s on Thu, 27 Feb, 12:20 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-733

  5. Tymoteusz Motylewski commented on patch set 2 02/27/20, 13:02

    LinkService.php:87

    t3://page?uid=23 the t3: without // is invalid, right?

    ContentObjectRenderer.php:706

    lets use =< (without space between opertators)
  6. Tymoteusz Motylewski voted on patch set 2 CR -1 02/27/20, 13:02

  7. Oli Bartsch uploaded patch set 3 02/27/20, 14:19

  8. Oli Bartsch commented on patch set 3 02/27/20, 14:20

    LinkService.php:87 Reply

    Done

    ContentObjectRenderer.php:706 Reply

    Done
  9. TYPO3com voted on patch set 3 V +1 02/27/20, 14:30 Completed build in 11m 15s on Thu, 27 Feb, 02:30 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-742

  10. Tymoteusz Motylewski voted on patch set 3 V +1 CR +1 02/27/20, 14:33

  11. Georg Ringer voted on patch set 3 V +2 CR +2 02/27/20, 14:39

  12. Georg Ringer merged patch set 4 02/27/20, 14:40