Review main Merged

63447[BUGFIX] Ensure presence of record uid for postModifiers of slugs

Susi Moog CR +2 V +2 Easy +3 −0 updated 02/27/20, 18:50

Commit message

When recreating a slug via the datahandler, the full record is present
in the hook, whereas when recreating the same slug via the ajax request
only a sub-set of values is sent. To ensure postModifiers are able
to recreate and modify slugs based on the original record, the handling
has been changed to always provide the record uid for further processing.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 67

  1. Susi Moog uploaded patch set 1 02/27/20, 12:49

  2. Susi Moog commented on patch set 1 02/27/20, 12:52

    How to test: Use news, add a postmodifier and var_dump/debug recordData in the modifier in the following cases: - empty slug field (will recreate on save) - press regenerate slug button next to field (will send ajax request)
  3. TYPO3com voted on patch set 1 V +1 02/27/20, 13:00 Completed build in 10m 30s on Thu, 27 Feb, 01:00 PM Test Summary: 71997 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-734

  4. Georg Ringer voted on patch set 1 V +2 CR +2 02/27/20, 13:54

  5. Georg Ringer voted on patch set 1 V +1 CR +1 02/27/20, 13:54

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 02/27/20, 18:50

  7. Daniel Goerz merged patch set 2 02/27/20, 18:50