Review 9.5 Merged

63448[BUGFIX] Fix Exception caused by empty staticPageArguments

Georg Ringer CR +2 V +2 Easy +2 −2 updated 02/27/20, 13:19

Commit message

When 'Index Records immediately when saved?' is enabled in indexing
configurations for records, then on saving the record the
string 'null' is used for this indexingconfiguration and passed to
SearchController::preparePageLink(), which expects an array and
therefore throws an exception.

This commit fixes this by checking if
$this->conf['staticPageArguments'] is an array and only then json_decode
that, else it sets the value to null.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 45

  1. Georg Ringer uploaded patch set 1 02/27/20, 13:07

  2. Georg Ringer commented on patch set 1 02/27/20, 13:07

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 02/27/20, 13:19 Completed build in 11m 48s on Thu, 27 Feb, 01:19 PM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-102

  4. Georg Ringer voted on patch set 1 V +2 CR +2 02/27/20, 13:19

  5. Georg Ringer merged patch set 2 02/27/20, 13:19