Review 9.5 Merged

63457[BUGFIX] Fix check for "ifEmpty" relevance

Susi Moog CR +2 V +2 Easy +2 −2 updated 02/28/20, 06:11

Commit message

The ContentObjectRenderer checks whether it is relevant or not to apply
the ifEmpty property before actually applying it. However the check does
not use the same condition as ifEmpty itself (PHP empty() vs trim()).
This patch ensures consistency while respecting the idea of the original
fix (avoid a useless processing).

NOTE: I have inverted the two conditions in the "if" statement following
a recommendation by the Php Inspections plugin of PhpStorm which said
that the condition about "ifBlank" was faster and should be executed
first.

Review

  • Code review CR +2 Done
    • Susi Moog +2
  • Verified V +2 Done
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 34

  1. Susi Moog commented on patch set 1 02/28/20, 05:35

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 02/28/20, 05:47 Completed build in 12m 24s on Fri, 28 Feb, 05:47 AM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-113

  3. Susi Moog commented on patch set 1 V +2 CR +2 02/28/20, 06:11

    straight backport.
  4. Susi Moog merged patch set 2 02/28/20, 06:11