Review 9.5 Merged

63462[BUGFIX] Evaluate invertStateDisplay in flexforms

Susi Moog CR +2 V +2 Easy +3 −3 updated 02/29/20, 20:19

Commit message

The option "invertStateDisplay" for checkboxes was not working with
flexforms, because the received true/false values from a flexform are
of type "string" and not of type "bool".
To correctly evaluate these values, the "invertStateDisplay" options
in the TcaCheckboxItems class are now cast to bool.

Review

  • Code review CR +2 Done
    • Susi Moog +2
  • Verified V +2 Done
    • Susi Moog +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 35

  1. Susi Moog commented on patch set 1 02/29/20, 19:52

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V -1 02/29/20, 20:04 Completed build in 11m 44s on Sat, 29 Feb, 08:04 PM Test Summary: 74342 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-125

  3. TYPO3com voted on patch set 1 V +1 02/29/20, 20:16 Completed build in 35m 32s on Sat, 29 Feb, 08:16 PM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-125

  4. Susi Moog commented on patch set 1 V +2 CR +2 02/29/20, 20:19

    straight backport.
  5. Susi Moog merged patch set 2 02/29/20, 20:19