Review 9.5 Merged

63467[BUGFIX] Remove possibility to exclude width/height in sys_file_metadata

Georg Ringer CR +2 V +2 Easy +0 −4 updated 03/05/20, 08:10

Commit message

Width and height are readonly fields updated by system image service API.
To ensure the API (for example the crop wizard) works flawlessly for
editors out of the box, width and height are no longer exclude fields.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oli Bartsch +1
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Georg Ringer commented on patch set 1 03/04/20, 07:25

    Cherry Picked from branch master.
  2. TYPO3com voted on patch set 1 V +1 03/04/20, 07:38 Completed build in 13m 13s on Wed, 4 Mar, 07:38 AM Test Summary: 74370 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-143

  3. Benni Mack updated the commit message in patch set 2 03/04/20, 08:00

  4. Stefan Froemken commented on patch set 2 V -1 03/04/20, 08:27

    After installing filemetadata extension the columns are hidden again
  5. TYPO3com voted on patch set 2 V +1 03/04/20, 08:37 Completed build in 19m 37s on Wed, 4 Mar, 08:37 AM Test Summary: 74370 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-149

  6. Georg Ringer commented on patch set 2 03/04/20, 09:03

    > Patch Set 2: Verified-1 > > After installing filemetadata extension the columns are hidden again that should also be wrong in master I guess
  7. Stefan Froemken commented on patch set 2 03/04/20, 09:29

    > Patch Set 2: > > > Patch Set 2: Verified-1 > > > > After installing filemetadata extension the columns are hidden again > > that should also be wrong in master I guess Jep, it is wrong there, too.
  8. Georg Ringer uploaded patch set 3 03/04/20, 11:00

  9. TYPO3com voted on patch set 3 V +1 03/04/20, 11:13 Completed build in 12m 18s on Wed, 4 Mar, 11:13 AM Test Summary: 74366 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-151

  10. Stefan Froemken voted on patch set 3 V +1 CR +1 03/04/20, 11:17

  11. Oli Bartsch voted on patch set 3 V +1 CR +1 03/04/20, 13:07

  12. Georg Ringer commented on patch set 3 V +2 CR +2 03/05/20, 08:10

    merged as this is basically a backport
  13. Georg Ringer merged patch set 4 03/05/20, 08:10