Review 9.5 Merged

63469[BUGFIX] Throw missing exception in method getTypeOfChildProperty

Alexander Schnitzler CR +2 V +2 Hard +557 −4 updated 03/06/20, 09:56

Commit message

Method getTypeOfChildProperty() of class ObjectConverter
didn't throw an exception if the class schema didn't detect
a type for the given child property. This could have led to
the case where said method returned void and resulted in a
type error exception.

Review

  • Code review CR +2 Done
    • Alexander Schnitzler +2
  • Verified V +2 Done
    • Alexander Schnitzler +2
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 57

  1. Alexander Schnitzler commented on patch set 1 03/05/20, 19:09

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Property/TypeConverter/ObjectConverter.php * typo3/sysext/extbase/Tests/Functional/Property/TypeConverter/ObjectConverterTest.php
  2. TYPO3com voted on patch set 1 V -1 03/05/20, 19:10 Completed build in 24s on Thu, 5 Mar, 07:10 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-155

  3. Alexander Schnitzler uploaded patch set 2 03/06/20, 09:40

  4. TYPO3com voted on patch set 2 V +1 03/06/20, 09:52 Completed build in 12m 13s on Fri, 6 Mar, 09:52 AM Test Summary: 74418 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-159

  5. Alexander Schnitzler commented on patch set 2 03/06/20, 09:55

    This change is ready for review.
  6. Alexander Schnitzler voted on patch set 2 V +2 CR +2 03/06/20, 09:56

  7. Alexander Schnitzler merged patch set 3 03/06/20, 09:56