Review main Merged

63479[TASK] Cleanup php doc blocks with rector

Alexander Schnitzler CR +2 V +2 Normal +43 −43 updated 02/28/20, 14:17

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oliver Klee +1
    • Björn Jacob +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Björn Jacob +1
    • TYPO3com +1 CI

Issues 1

Files 32

Show 12 more files

Review log 913

  1. Alexander Schnitzler uploaded patch set 1 02/28/20, 10:03

  2. TYPO3com voted on patch set 1 V -1 02/28/20, 10:18 Completed build in 13m 59s on Fri, 28 Feb, 10:18 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-780

  3. Alexander Schnitzler uploaded patch set 2 02/28/20, 10:30

  4. Oliver Klee commented on patch set 2 02/28/20, 10:44

    DocumentTemplate.php:633 Unresolved

    There should be a second double quote.
  5. TYPO3com voted on patch set 2 V +1 02/28/20, 10:46 Completed build in 15m 46s on Fri, 28 Feb, 10:46 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-783

  6. Alexander Schnitzler commented on patch set 2 02/28/20, 10:47

    This change is ready for review.
  7. Alexander Schnitzler commented on patch set 3 02/28/20, 12:33

    Published edit on patch set 2.
  8. Oliver Klee voted on patch set 3 CR +1 02/28/20, 12:38

  9. Björn Jacob voted on patch set 3 V +1 CR +1 02/28/20, 12:42

  10. TYPO3com voted on patch set 3 V -1 02/28/20, 12:44 Completed build in 10m 13s on Fri, 28 Feb, 12:44 PM Test Summary: 6 of 72535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-787

  11. TYPO3com voted on patch set 3 V +1 02/28/20, 12:53 Completed build in 30m 09s on Fri, 28 Feb, 12:53 PM Test Summary: 72050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-787

  12. Daniel Goerz voted on patch set 3 V +2 CR +2 02/28/20, 14:17

  13. Daniel Goerz merged patch set 4 02/28/20, 14:17