63481[TASK] Remove superfluous isset checks
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/backend/Classes/Form/FieldWizard/LocalizationStateSelector.php1+1 −4
- typo3/sysext/backend/Classes/Utility/BackendUtility.php+3 −0
- typo3/sysext/core/Classes/Localization/Parser/AbstractXmlParser.php+1 −1
- typo3/sysext/core/Classes/Localization/Parser/LocallangXmlParser.php+1 −1
- typo3/sysext/core/Classes/Resource/Index/Indexer.php+1 −1
- typo3/sysext/core/Classes/Resource/ResourceFactory.php+1 −1
- typo3/sysext/frontend/Classes/ContentObject/ContentObjectRenderer.php+3 −0
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php+1 −1
- phpstan.neon+15 −0
Review log 1016
-
Alexander Schnitzler uploaded patch set 1 02/28/20, 14:24
-
TYPO3com voted on patch set 1 V +1 02/28/20, 14:35 Completed build in 10m 55s on Fri, 28 Feb, 02:35 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-791
-
Alexander Schnitzler wrote 02/28/20, 14:37
Topic set to phpstan -
Alexander Schnitzler updated the commit message in patch set 2 02/28/20, 14:40
-
TYPO3com voted on patch set 2 V +1 02/28/20, 14:59 Completed build in 17m 42s on Fri, 28 Feb, 02:59 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-796
-
Susi Moog updated the commit message in patch set 3 02/28/20, 15:06
-
TYPO3com voted on patch set 3 V +1 02/28/20, 15:19 Completed build in 13m 04s on Fri, 28 Feb, 03:19 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-798
-
Alexander Schnitzler updated the commit message in patch set 4 02/29/20, 17:28
-
TYPO3com voted on patch set 4 V -1 02/29/20, 17:38 Completed build in 10m 39s on Sat, 29 Feb, 05:38 PM Test Summary: 72038 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-864
-
TYPO3com voted on patch set 4 V +1 02/29/20, 17:44 Completed build in 27m 32s on Sat, 29 Feb, 05:44 PM Test Summary: 72047 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-864
-
Alexander Schnitzler uploaded patch set 5 03/01/20, 11:04
-
TYPO3com voted on patch set 5 V +1 03/01/20, 11:15 Completed build in 10m 25s on Sun, 1 Mar, 11:15 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-889
-
Benni Mack commented on patch set 5 V +1 CR +1 03/02/20, 10:39
LocalizationStateSelector.php:40UnresolvedLOL! -
Oli Bartsch voted on patch set 5 V +1 CR +1 03/02/20, 11:03
-
Benni Mack voted on patch set 5 V +2 CR +2 03/02/20, 11:18
-
Benni Mack merged patch set 6 03/02/20, 11:18