Review main Merged

63481[TASK] Remove superfluous isset checks

Alexander Schnitzler CR +2 V +2 Easy +27 −9 updated 03/02/20, 11:18

Commit message

phpstan reported superfluous usages of isset checks for
variables that are defined and whose type is more
specifically checked in the same condition.

Some reported errors of phpstan have been ignored for now
as they are considered false positives and which will be
tackled once there is more type safety in the context of
those reported errors to be able to properly replace the
isset checks.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1016

  1. Alexander Schnitzler uploaded patch set 1 02/28/20, 14:24

  2. TYPO3com voted on patch set 1 V +1 02/28/20, 14:35 Completed build in 10m 55s on Fri, 28 Feb, 02:35 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-791

  3. Alexander Schnitzler wrote 02/28/20, 14:37

    Topic set to phpstan
  4. Alexander Schnitzler updated the commit message in patch set 2 02/28/20, 14:40

  5. TYPO3com voted on patch set 2 V +1 02/28/20, 14:59 Completed build in 17m 42s on Fri, 28 Feb, 02:59 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-796

  6. Susi Moog updated the commit message in patch set 3 02/28/20, 15:06

  7. TYPO3com voted on patch set 3 V +1 02/28/20, 15:19 Completed build in 13m 04s on Fri, 28 Feb, 03:19 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-798

  8. Alexander Schnitzler updated the commit message in patch set 4 02/29/20, 17:28

  9. TYPO3com voted on patch set 4 V -1 02/29/20, 17:38 Completed build in 10m 39s on Sat, 29 Feb, 05:38 PM Test Summary: 72038 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-864

  10. TYPO3com voted on patch set 4 V +1 02/29/20, 17:44 Completed build in 27m 32s on Sat, 29 Feb, 05:44 PM Test Summary: 72047 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-864

  11. Alexander Schnitzler uploaded patch set 5 03/01/20, 11:04

  12. TYPO3com voted on patch set 5 V +1 03/01/20, 11:15 Completed build in 10m 25s on Sun, 1 Mar, 11:15 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-889

  13. Benni Mack commented on patch set 5 V +1 CR +1 03/02/20, 10:39

    LocalizationStateSelector.php:40 Unresolved

    LOL!
  14. Oli Bartsch voted on patch set 5 V +1 CR +1 03/02/20, 11:03

  15. Benni Mack voted on patch set 5 V +2 CR +2 03/02/20, 11:18

  16. Benni Mack merged patch set 6 03/02/20, 11:18