Review main Merged

63482[BUGFIX] Add type definition for backend user section

Susi Moog CR +2 V +2 Easy +32 −0 updated 02/28/20, 15:52

Commit message

Since columnsOverrides it is possible to overwrite TCA definitions
for specific columns and type combinations. However, as there is no
specific type definition for backend user sections, the default type
(and its overrides) were used. Backend user section was the only
undefined type. The type definition has now been added.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Susi Moog uploaded patch set 1 02/28/20, 15:03

  2. TYPO3com voted on patch set 1 V +1 02/28/20, 15:14 Completed build in 10m 53s on Fri, 28 Feb, 03:14 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-797

  3. Daniel Goerz commented on patch set 1 02/28/20, 15:15

    The dokytype now lacks the tabs and fields added by ext:seo that it had before but I guess those are kind of pointless for backend user sections anyway, right?
  4. Susi Moog commented on patch set 1 02/28/20, 15:17

    > Patch Set 1: > > The dokytype now lacks the tabs and fields added by ext:seo that it had before but I guess those are kind of pointless for backend user sections anyway, right? ehm. yes. they are. pointless.
  5. Daniel Goerz voted on patch set 1 V +1 CR +1 02/28/20, 15:22

  6. Oli Bartsch voted on patch set 1 CR +1 02/28/20, 15:49

  7. Oli Bartsch voted on patch set 1 V +1 02/28/20, 15:50

  8. Daniel Goerz voted on patch set 1 V +2 CR +2 02/28/20, 15:52

  9. Daniel Goerz merged patch set 2 02/28/20, 15:52