63483[TASK] Avoid possibly undefined variables
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Oliver Klee +1
- Guido Schmechel +1
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 7
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php+1 −1
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaFlexPrepare.php2+1 −0
- typo3/sysext/backend/Classes/View/PageLayoutView.php+2 −0
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php3+1 −0
- typo3/sysext/core/Classes/DataHandling/DataHandler.php+1 −0
- typo3/sysext/indexed_search/Classes/Hook/CrawlerHook.php+1 −0
- typo3/sysext/indexed_search/Classes/Indexer.php+1 −0
Review log 1927
Show 2 earlier messages
-
Alexander Schnitzler uploaded patch set 1 02/28/20, 16:20
-
Alexander Schnitzler wrote 02/28/20, 16:20
Topic set to phpstan
-
TYPO3com voted on patch set 1 V -1 02/28/20, 16:46 Completed build in 25m 38s on Fri, 28 Feb, 04:46 PM Test Summary: 4132 of 61914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-801
-
Alexander Schnitzler uploaded patch set 2 02/28/20, 17:53
-
TYPO3com voted on patch set 2 V -1 02/28/20, 18:03 Completed build in 10m 07s on Fri, 28 Feb, 06:03 PM Test Summary: 61810 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-806
-
TYPO3com voted on patch set 2 V +1 02/28/20, 18:35 Completed build in 52m 07s on Fri, 28 Feb, 06:35 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-806
-
Alexander Schnitzler updated the commit message in patch set 3 02/28/20, 18:49
-
TYPO3com voted on patch set 3 V +1 02/28/20, 19:00 Completed build in 11m 05s on Fri, 28 Feb, 07:00 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-807
-
Georg Ringer commented on patch set 3 CR -1 02/28/20, 20:03
BackendUserAuthentication.php:375this needs to be moved down and still would create notices because of access to undefined key -
Alexander Schnitzler commented on patch set 3 02/28/20, 21:06
BackendUserAuthentication.php:375ReplyCan you explain this in more detail please? I don't get it. -
Alexander Schnitzler commented on patch set 3 02/29/20, 17:33
BackendUserAuthentication.php:375ReplySolved in private slack discussion. -
Alexander Schnitzler uploaded patch set 4 02/29/20, 17:34
-
TYPO3com voted on patch set 4 V -1 02/29/20, 17:45 Completed build in 10m 19s on Sat, 29 Feb, 05:45 PM Test Summary: 72050 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-865
-
TYPO3com voted on patch set 4 V +1 03/01/20, 09:30 Completed build in 16h 06m 28s on Sun, 1 Mar, 09:30 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-865
-
Mathias Brodala commented on patch set 4 03/02/20, 10:29
TcaFlexPrepare.php:86Shouldn't this be NULL to mimic the current behavior? -
Guido Schmechel commented on patch set 4 03/02/20, 10:32
TcaInline.php:200Short question: For me this is a bug instead of a phpStan rule. Should we move this into a separate patch? -
Alexander Schnitzler rebased onto patch set 5 03/02/20, 19:41
-
Alexander Schnitzler commented on patch set 5 03/02/20, 19:41
TcaFlexPrepare.php:86Reply UnresolvedYes. You are right.TcaInline.php:200Reply UnresolvedI am fine with that. -
Alexander Schnitzler uploaded patch set 6 03/02/20, 19:43
-
TYPO3com voted on patch set 5 V +1 03/02/20, 19:55 Completed build in 13m 31s on Mon, 2 Mar, 07:55 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-926
-
TYPO3com voted on patch set 6 V +1 03/02/20, 19:58 Completed build in 12m 24s on Mon, 2 Mar, 07:58 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-927
-
Alexander Schnitzler commented on patch set 6 03/06/20, 10:36
ping -
Guido Schmechel voted on patch set 6 CR +1 03/06/20, 10:40
-
Oliver Klee voted on patch set 6 CR +1 03/06/20, 11:28
-
Frank Nägler voted on patch set 6 V +1 CR +1 03/06/20, 12:22
-
Andreas Kienast voted on patch set 6 V +2 CR +2 03/06/20, 12:26
-
Andreas Kienast merged patch set 7 03/06/20, 12:26