Review main Merged

63485[BUGFIX] Fix Dashboard RSS widgets cache life time handling

Susi Moog CR +2 V +2 Easy +1 −1 updated 02/29/20, 08:15

Commit message

The SimpleFileBackend does not support cache life times, so RSS
feeds are currently cached "forever". Using the FileBackend instead
works as intended.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • Daniel Siepmann +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Georg Ringer +1
    • Oli Bartsch +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Susi Moog uploaded patch set 1 02/28/20, 17:08

  2. TYPO3com voted on patch set 1 V +1 02/28/20, 17:18 Completed build in 10m 47s on Fri, 28 Feb, 05:18 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-804

  3. Georg Ringer voted on patch set 1 V +1 CR +1 02/28/20, 17:25

  4. Oli Bartsch commented on patch set 1 V -1 02/28/20, 18:28

    Could we please also use tags here to make it possible to manage the cache of widgets, using `dashboard_rss`, independent from each other.
  5. Oli Bartsch commented on patch set 1 V +1 CR +1 02/28/20, 19:12

    Oke, looks like they are already acting independent with this change.
  6. Alexander Schnitzler voted on patch set 1 V +1 CR +1 02/28/20, 19:42

  7. Daniel Siepmann voted on patch set 1 CR +1 02/29/20, 07:17

  8. Daniel Goerz voted on patch set 1 V +2 CR +2 02/29/20, 08:15

  9. Daniel Goerz merged patch set 2 02/29/20, 08:15