Review main Merged

63488[BUGFIX] Only allow scalar values in AssetCollector

Helmut Hummel CR +2 V +2 Easy +29 −18 updated 03/29/22, 07:38

Commit message

Since AssetCollector needs to be serialized,
or to be more precise its state need to be cached as string,
we must avoid that state is stored that isn't serializable.

Therefore we adapt the API to reflect this and change
the API calls to not add non serializable objects.

With this change we also revert the previous USER_INT fix
that bound the AssetCollector unnecessarily to PageRenderer
and store it serialized in cache (the deserialization was
already part of the code of the commit that introduced
the AssetCollector).

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 69

  1. Helmut Hummel uploaded patch set 1 02/28/20, 19:47

  2. TYPO3com voted on patch set 1 V -1 02/28/20, 19:58 Completed build in 10m 32s on Fri, 28 Feb, 07:58 PM Test Summary: 19 of 72535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-809

  3. Susi Moog uploaded patch set 2 02/29/20, 05:55

  4. TYPO3com voted on patch set 2 V -1 02/29/20, 06:26 Completed build in 21m 10s on Sat, 29 Feb, 06:26 AM Test Summary: 68791 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-829

  5. TYPO3com voted on patch set 2 V +1 02/29/20, 06:53 Completed build in 1h 44m 35s on Sat, 29 Feb, 06:53 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-829

  6. Susi Moog voted on patch set 2 V +1 CR +1 02/29/20, 07:08

  7. Daniel Goerz voted on patch set 2 V +2 CR +2 02/29/20, 08:09

  8. Daniel Goerz merged patch set 3 02/29/20, 08:10

  9. Christian Kuhn commented on patch set 3 03/29/22, 07:38

    ContentObjectRenderer.php:1096 Unresolved

    this access is broken now.