Review main Merged

63493[BUGFIX] Fix spelling errors in ext:impexp

Christian Eßl CR +2 V +2 Easy +5 −5 updated 02/29/20, 08:45

Commit message

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1621

  1. Christian Eßl uploaded patch set 1 02/28/20, 20:40

  2. TYPO3com voted on patch set 1 V +1 02/28/20, 21:00 Completed build in 19m 39s on Fri, 28 Feb, 09:00 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-817

  3. Christian Eßl updated the commit message in patch set 2 02/28/20, 21:10

  4. TYPO3com voted on patch set 2 V +1 02/28/20, 21:31 Completed build in 16m 37s on Fri, 28 Feb, 09:31 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-821

  5. Björn Jacob commented on patch set 2 CR -1 02/28/20, 21:51

    ImportExport.php:1116

    "memory records"
  6. Oli Bartsch commented on patch set 2 02/29/20, 05:27

    ImportExport.php:1116

    Maybe replace this with ‘containing’. Also above.
  7. Susi Moog commented on patch set 3 02/29/20, 06:42

    Published edit on patch set 2.
  8. Susi Moog commented on patch set 2 02/29/20, 06:42

    ImportExport.php:1116 Reply

    Done

    ImportExport.php:1116 Reply Unresolved

    Tried, sounded weirder than before tbh.
  9. Georg Ringer voted on patch set 3 V +1 CR +1 02/29/20, 06:44

  10. Björn Jacob voted on patch set 3 V +1 CR +1 02/29/20, 06:45

  11. Alexander Schnitzler commented on patch set 3 02/29/20, 07:01

    Import.php:1122

    I am not sure but isn't memory's meant here? I wouldn't know which memories we are dealing with here. Isn't this about the RAM?
  12. Björn Jacob commented on patch set 3 02/29/20, 07:04

    I am not totally sure either. Maybe we can ask an English professional.
  13. TYPO3com voted on patch set 3 V +1 02/29/20, 07:05 Completed build in 21m 00s on Sat, 29 Feb, 07:05 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-833

  14. Susi Moog commented on patch set 3 02/29/20, 07:07

    > Patch Set 3: > > I am not totally sure either. Maybe we can ask an English professional.

    Import.php:1122 Reply Unresolved

    it might be that the word memory is superfluous "contains a register of all records that were loaded" probably says the same thing...
  15. Susi Moog commented on patch set 4 02/29/20, 08:22

    Published edit on patch set 3.
  16. Susi Moog commented on patch set 4 02/29/20, 08:23

    (checked meriam webster ;))
  17. Daniel Goerz voted on patch set 4 V +1 CR +1 02/29/20, 08:30

  18. TYPO3com voted on patch set 4 V -1 02/29/20, 08:34 Completed build in 11m 17s on Sat, 29 Feb, 08:34 AM Test Summary: 2 of 72535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-838

  19. TYPO3com voted on patch set 4 V +1 02/29/20, 08:44 Completed build in 33m 02s on Sat, 29 Feb, 08:44 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-838

  20. Susi Moog voted on patch set 4 V +2 CR +2 02/29/20, 08:45

  21. Susi Moog merged patch set 5 02/29/20, 08:45