Review main Merged

63495[BUGFIX] Fix spelling errors in ext:t3editor

Christian Eßl CR +2 V +2 Normal +47 −47 updated 02/29/20, 08:28

Commit message

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1316

  1. Christian Eßl uploaded patch set 1 02/28/20, 20:54

  2. TYPO3com voted on patch set 1 V +1 02/28/20, 21:09 Completed build in 14m 24s on Fri, 28 Feb, 09:09 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-819

  3. Björn Jacob commented on patch set 1 CR -1 02/28/20, 21:27

    tsref.xml:3520

    "and"

    tsref.xml:3626

    IMHO should be "Meta tag". There are multiple occurrences.

    tsref.xml:3769

    IMHO should be "page title".

    tsref.xml:4448

    Should it be: "These are the extensions..."

    tsref.xml:5429

    "https"
  4. Björn Jacob commented on patch set 2 02/29/20, 06:48

    Published edit on patch set 1.
  5. Björn Jacob commented on patch set 2 V +1 CR +1 02/29/20, 06:52

    tsref.xml:3520 Reply

    Done

    tsref.xml:3626 Reply

    Done

    tsref.xml:3769 Reply

    Done

    tsref.xml:4448 Reply

    Done

    tsref.xml:5429 Reply

    Done
  6. TYPO3com voted on patch set 2 V +1 02/29/20, 07:13 Completed build in 17m 39s on Sat, 29 Feb, 07:13 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-834

  7. Daniel Goerz voted on patch set 2 CR -1 02/29/20, 07:54

  8. Daniel Goerz commented on patch set 2 02/29/20, 07:56

    tsref.xml:4124

    Dont get this change
  9. Susi Moog commented on patch set 2 02/29/20, 08:01

    tsref.xml:4124 Reply

    that's probably: bringing the example into 2020 instead of 1998 - cooliris is dead (bought by Yahoo in 2014 ...)
  10. Daniel Goerz commented on patch set 2 02/29/20, 08:02

    tsref.xml:4124 Reply

    yes but now we are including JS?
  11. Susi Moog commented on patch set 2 02/29/20, 08:08

    tsref.xml:4124 Reply Unresolved

    lol. you are right as always ;) care to adjust to something more sensible?
  12. Daniel Goerz commented on patch set 3 02/29/20, 08:12

    Published edit on patch set 2.
  13. TYPO3com voted on patch set 3 V +1 02/29/20, 08:24 Completed build in 11m 25s on Sat, 29 Feb, 08:24 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-837

  14. Susi Moog voted on patch set 3 V +1 CR +1 02/29/20, 08:26

  15. Daniel Goerz voted on patch set 3 V +2 CR +2 02/29/20, 08:27

  16. Daniel Goerz merged patch set 4 02/29/20, 08:28