Review main Merged

63501[TASK] Change several uris in ext:about to https

Christian Eßl CR +2 V +2 Easy +11 −11 updated 02/29/20, 18:23

Commit message

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Björn Jacob +1
    • Guido Schmechel +1
    • Alexander Schnitzler +1
  • Verified V +2 Done
    • Susi Moog +2
    • Björn Jacob +1
    • Guido Schmechel +1
    • Alexander Schnitzler +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Christian Eßl uploaded patch set 1 02/29/20, 09:01

  2. Oli Bartsch commented on patch set 1 02/29/20, 09:06

    Do really all this domains feature :443?
  3. TYPO3com voted on patch set 1 V +1 02/29/20, 09:14 Completed build in 12m 39s on Sat, 29 Feb, 09:14 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-845

  4. Alexander Schnitzler commented on patch set 1 V +1 CR +1 02/29/20, 17:40

    > Patch Set 1: > > > Patch Set 1: > > > > Do really all this domains feature :443? > > http://getbootstrap.com > redirects to https://getbootstrap.com > > http://www.doctrine-project.org/projects/dbal.html > redirects to https://www.doctrine-project.org/projects/dbal.html > > http://ckeditor.com > redirects to https://ckeditor.com > > http://requirejs.org > redirects to https://requirejs.org > > http://ricostacruz.com/nprogress/ > no redirection, but https://ricostacruz.com/nprogress/ works > > http://www.jacklmoore.com/autosize/ > no redirection but https://www.jacklmoore.com/autosize/ works > > http://imagesloaded.desandro.com > no redirection; https://imagesloaded.desandro.com still not secure > > http://seiyria.com/bootstrap-slider > no redirection but https://seiyria.com/bootstrap-slider works > > http://labs.abeautifulsite.net/jquery-minicolors > redirects to https://labs.abeautifulsite.net/jquery-minicolors > > http://wjbryant.github.io/taboverride/ > no redirection but https://wjbryant.github.io/taboverride/ works > > http://codemirror.net. > redirects to https://codemirror.net I checked all sites as well and all support https. https://imagesloaded.desandro.com uses https as well for the main connection. Images loaded via http are a pity but I wouldn't let that make us link to http.
  5. Björn Jacob voted on patch set 1 V +1 CR +1 02/29/20, 17:49

  6. Guido Schmechel voted on patch set 1 V +1 CR +1 02/29/20, 18:00

  7. Susi Moog voted on patch set 1 V +2 CR +2 02/29/20, 18:22

  8. Susi Moog merged patch set 2 02/29/20, 18:23