Review main Merged

63503[BUGFIX] Initialize label related properties in EmulatedPageLayoutView

Christian Eßl CR +2 V +2 Easy +2 −0 updated 03/01/20, 17:12

Commit message

The new StandardContentPreviewRenderer uses an emulated PageLayoutView
for implementing "tt_content_drawItem" hooks. This patch makes sure
both the member variables $CType_labels and $itemLabels are set for
the emulated view as those properties may be accessed in a hook.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1421

  1. Christian Eßl uploaded patch set 1 02/29/20, 10:30

  2. TYPO3com voted on patch set 1 V -1 02/29/20, 10:40 Completed build in 10m 27s on Sat, 29 Feb, 10:40 AM Test Summary: 10 of 72529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-849

  3. TYPO3com commented on patch set 1 02/29/20, 12:16 Completed build in 11m 42s on Sat, 29 Feb, 12:16 PM Test Summary: 71746 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-853

  4. TYPO3com voted on patch set 1 V +1 02/29/20, 12:23 Completed build in 30m 02s on Sat, 29 Feb, 12:23 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-853

  5. Susi Moog commented on patch set 1 V +1 CR +1 02/29/20, 18:14

    nice, just ran into this one. for ext:form we should probably rebuild the hook in a next step, as the whole class is deprecated and we want to avoid shipping things using deprecated API - but for other 3rd parties this is probably an important BC fix.
  6. Daniel Goerz commented on patch set 1 02/29/20, 18:51

    StandardContentPreviewRenderer.php:253

    shouldn't we rather assure that those public (!) properties are set on the "emulatedPageLayoutView"?
  7. Susi Moog commented on patch set 1 V 0 CR 0 02/29/20, 18:57

    secondary problem might be that this fixes form, however all the other old hooks have probably the same problem and we should check that.
  8. Claus Due commented on patch set 1 03/01/20, 07:54

    StandardContentPreviewRenderer.php:253 Reply

    Yes, that would be best. The required data exists in DrawingConfiguration and can be transferred to the emulated instance withtout the need to change method signatures or perform a DB query every time. See DrawingConfiguration->getContentTypeLabels / ->getItemLabels.
  9. Christian Eßl uploaded patch set 2 03/01/20, 08:18

  10. Christian Eßl updated the commit message in patch set 3 03/01/20, 08:19

  11. Christian Eßl commented on patch set 3 03/01/20, 08:20

    StandardContentPreviewRenderer.php:253 Reply

    Ack
  12. TYPO3com voted on patch set 2 V -1 03/01/20, 08:31 Completed build in 12m 15s on Sun, 1 Mar, 08:31 AM Test Summary: 71751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-881

  13. TYPO3com voted on patch set 3 V +1 03/01/20, 08:36 Completed build in 14m 24s on Sun, 1 Mar, 08:36 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-882

  14. Claus Due voted on patch set 3 CR +1 03/01/20, 08:50

  15. TYPO3com commented on patch set 3 03/01/20, 08:52 Completed build in 16m 03s on Sun, 1 Mar, 08:52 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-885

  16. Daniel Goerz updated the commit message in patch set 4 03/01/20, 16:17

  17. Daniel Goerz voted on patch set 4 V +1 CR +1 03/01/20, 16:17

  18. TYPO3com voted on patch set 4 V +1 03/01/20, 16:27 Completed build in 10m 24s on Sun, 1 Mar, 04:27 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-893

  19. Oli Bartsch voted on patch set 4 V +1 CR +1 03/01/20, 16:46

  20. Daniel Goerz voted on patch set 4 V +2 CR +2 03/01/20, 17:12

  21. Daniel Goerz merged patch set 5 03/01/20, 17:12