63503[BUGFIX] Initialize label related properties in EmulatedPageLayoutView
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
-
Verified V +2 Done
- Daniel Goerz +2
- Oli Bartsch +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1421
-
Christian Eßl uploaded patch set 1 02/29/20, 10:30
-
TYPO3com voted on patch set 1 V -1 02/29/20, 10:40 Completed build in 10m 27s on Sat, 29 Feb, 10:40 AM Test Summary: 10 of 72529 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-849
-
TYPO3com commented on patch set 1 02/29/20, 12:16 Completed build in 11m 42s on Sat, 29 Feb, 12:16 PM Test Summary: 71746 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-853
-
TYPO3com voted on patch set 1 V +1 02/29/20, 12:23 Completed build in 30m 02s on Sat, 29 Feb, 12:23 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-853
-
Susi Moog commented on patch set 1 V +1 CR +1 02/29/20, 18:14
nice, just ran into this one. for ext:form we should probably rebuild the hook in a next step, as the whole class is deprecated and we want to avoid shipping things using deprecated API - but for other 3rd parties this is probably an important BC fix. -
Daniel Goerz commented on patch set 1 02/29/20, 18:51
StandardContentPreviewRenderer.php:253shouldn't we rather assure that those public (!) properties are set on the "emulatedPageLayoutView"? -
Susi Moog commented on patch set 1 V 0 CR 0 02/29/20, 18:57
secondary problem might be that this fixes form, however all the other old hooks have probably the same problem and we should check that. -
Claus Due commented on patch set 1 03/01/20, 07:54
StandardContentPreviewRenderer.php:253ReplyYes, that would be best. The required data exists in DrawingConfiguration and can be transferred to the emulated instance withtout the need to change method signatures or perform a DB query every time. See DrawingConfiguration->getContentTypeLabels / ->getItemLabels. -
Christian Eßl uploaded patch set 2 03/01/20, 08:18
-
Christian Eßl updated the commit message in patch set 3 03/01/20, 08:19
-
Christian Eßl commented on patch set 3 03/01/20, 08:20
StandardContentPreviewRenderer.php:253ReplyAck -
TYPO3com voted on patch set 2 V -1 03/01/20, 08:31 Completed build in 12m 15s on Sun, 1 Mar, 08:31 AM Test Summary: 71751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-881
-
TYPO3com voted on patch set 3 V +1 03/01/20, 08:36 Completed build in 14m 24s on Sun, 1 Mar, 08:36 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-882
-
Claus Due voted on patch set 3 CR +1 03/01/20, 08:50
-
TYPO3com commented on patch set 3 03/01/20, 08:52 Completed build in 16m 03s on Sun, 1 Mar, 08:52 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-885
-
Daniel Goerz updated the commit message in patch set 4 03/01/20, 16:17
-
Daniel Goerz voted on patch set 4 V +1 CR +1 03/01/20, 16:17
-
TYPO3com voted on patch set 4 V +1 03/01/20, 16:27 Completed build in 10m 24s on Sun, 1 Mar, 04:27 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-893
-
Oli Bartsch voted on patch set 4 V +1 CR +1 03/01/20, 16:46
-
Daniel Goerz voted on patch set 4 V +2 CR +2 03/01/20, 17:12
-
Daniel Goerz merged patch set 5 03/01/20, 17:12