Review main Merged

63504[BUGFIX] Initialize CodeMirror if element becomes visible to client

Andreas Kienast CR +2 V +2 Normal +77 −62 updated 02/29/20, 18:11

Commit message

CodeMirror initialization fails if its textarea is not rendered yet. To
fix this issue, an Intersection Observer is installed and initializes the
CodeMirror instance when the element becomes visibile to the client.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Christian Eßl +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Riccardo De Contardi +1
    • Christian Eßl +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 810

  1. Andreas Kienast uploaded patch set 1 02/29/20, 11:40

  2. Andreas Kienast commented on patch set 1 02/29/20, 11:41

    I'll take care of the 9.5 backport by myself because the IntersectionObserver API is not available in Internet Explorer at all.
  3. TYPO3com voted on patch set 1 V +1 02/29/20, 11:50 Completed build in 09m 50s on Sat, 29 Feb, 11:50 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-850

  4. Christian Eßl voted on patch set 1 V +1 CR +1 02/29/20, 12:20

  5. Andreas Kienast uploaded patch set 2 02/29/20, 13:26

  6. TYPO3com voted on patch set 2 V +1 02/29/20, 13:36 Completed build in 10m 03s on Sat, 29 Feb, 01:36 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-856

  7. Christian Eßl voted on patch set 2 V +1 CR +1 02/29/20, 14:28

  8. Riccardo De Contardi commented on patch set 2 V +1 02/29/20, 16:49

    verified with TS template, Page, BE User and BE usergroup
  9. Daniel Goerz voted on patch set 2 V +2 CR +2 02/29/20, 18:11

  10. Daniel Goerz merged patch set 3 02/29/20, 18:11