Review main Merged

63506[BUGFIX] Evaluate invertStateDisplay in flexforms

Christian Eßl CR +2 V +2 Easy +3 −3 updated 02/29/20, 19:52

Commit message

The option "invertStateDisplay" for checkboxes was not working with
flexforms, because the received true/false values from a flexform are
of type "string" and not of type "bool".
To correctly evaluate these values, the "invertStateDisplay" options
in the TcaCheckboxItems class are now cast to bool.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Daniel Goerz +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Christian Eßl uploaded patch set 1 02/29/20, 12:02

  2. Andreas Kienast voted on patch set 1 CR +1 02/29/20, 12:13

  3. TYPO3com voted on patch set 1 V -1 02/29/20, 12:13 Completed build in 11m 06s on Sat, 29 Feb, 12:13 PM Test Summary: 71760 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-852

  4. TYPO3com voted on patch set 1 V +1 02/29/20, 12:24 Completed build in 33m 29s on Sat, 29 Feb, 12:24 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-852

  5. Oli Bartsch voted on patch set 1 CR +1 02/29/20, 12:33

  6. Daniel Goerz voted on patch set 1 V +1 CR +1 02/29/20, 19:36

  7. Susi Moog commented on patch set 1 V +2 CR +2 02/29/20, 19:52

  8. Susi Moog merged patch set 2 02/29/20, 19:52