Review 9.5 Merged

63507[BUGFIX] Initialize CodeMirror if element becomes visible to client

Andreas Kienast CR +2 V +2 Normal +85 −55 updated 03/01/20, 17:17

Commit message

CodeMirror initialization fails if its textarea is not rendered yet. To
fix this issue, an Intersection Observer is installed and initializes the
CodeMirror instance when the element becomes visibile to the client.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 8

Review log 69

  1. Andreas Kienast uploaded patch set 1 02/29/20, 12:11

  2. TYPO3com voted on patch set 1 V -1 02/29/20, 12:23 Completed build in 11m 27s on Sat, 29 Feb, 12:23 PM Test Summary: 74005 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-119

  3. Andreas Kienast uploaded patch set 2 02/29/20, 12:52

  4. TYPO3com voted on patch set 2 V +1 02/29/20, 13:04 Completed build in 12m 04s on Sat, 29 Feb, 01:04 PM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-120

  5. Andreas Kienast uploaded patch set 3 02/29/20, 14:01

  6. TYPO3com voted on patch set 3 V +1 02/29/20, 14:13 Completed build in 11m 10s on Sat, 29 Feb, 02:13 PM Test Summary: 74351 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-121

  7. Susi Moog voted on patch set 3 V +1 CR +1 02/29/20, 20:44

  8. Daniel Goerz voted on patch set 3 V +2 CR +2 03/01/20, 17:17

  9. Daniel Goerz merged patch set 4 03/01/20, 17:17