Review main Abandoned

63508[TASK] Remove old IE https download related hack in http headers

Christian Eßl CR 0 V 0 Easy +0 −22 updated 03/01/20, 18:29

Commit message

Older Internet Explorer browsers had problems downloading files over
https with cache control headers. AbstractBackendUserAuthentication
contained a very old fix to circumvent this problem.
As this problem only affected older IE versions and Internet Explorer
isn't supported anymore in TYPO3 10 at all, it is safe to remove this
old hack.

Review

  • Code review CR 0
  • Verified V 0

Issues 2

Files 2

Review log 69

  1. Christian Eßl uploaded patch set 1 02/29/20, 12:30

  2. TYPO3com voted on patch set 1 V -1 02/29/20, 12:31 Completed build in 20s on Sat, 29 Feb, 12:31 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-854

  3. Andreas Kienast uploaded patch set 2 02/29/20, 13:04

  4. TYPO3com voted on patch set 2 V -1 02/29/20, 13:14 Completed build in 10m 04s on Sat, 29 Feb, 01:14 PM Test Summary: 72045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-855

  5. TYPO3com voted on patch set 2 V +1 02/29/20, 13:17 Completed build in 22m 47s on Sat, 29 Feb, 01:17 PM Test Summary: 72045 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-855

  6. Susi Moog commented on patch set 2 02/29/20, 18:48

    Careful with statements like this please. What's true: the backend does not support IE. The frontend should support whatever you want it to support - we can argue that IE 5.5 actually does not make sense, IE 9 and up however might still need to be supported by some web sites. And as this is AbstractUserAuthentication which is also used in frontend we should be very sure we don't break stuff here.
  7. Susi Moog commented on patch set 2 02/29/20, 18:52

    This seems to be a problem at least up to IE 9 from a short google search (see https://confluence.atlassian.com/jirakb/unable-to-open-attachments-on-internet-explorer-over-https-296912290.html )
  8. Christian Eßl commented on patch set 2 03/01/20, 18:29

    Reply Unresolved

    You are right. - Completely forgot about that part. :D. I will abandon the patch.
  9. Christian Eßl abandoned the change 03/01/20, 18:29