63510[TASK] Improve performance of InMemoryLogWriter
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 5
- typo3/sysext/adminpanel/Classes/Log/InMemoryLogWriter.php+42 −1
- typo3/sysext/adminpanel/Classes/Modules/Debug/Log.php+6 −0
- typo3/sysext/adminpanel/Resources/Private/Language/locallang_debug.xlf+3 −0
- typo3/sysext/adminpanel/Resources/Private/Templates/Modules/Debug/Log.html+18 −0
- typo3/sysext/adminpanel/ext_localconf.php+3 −1
Review log 57
-
Christian Eßl uploaded patch set 1 02/29/20, 13:54
-
TYPO3com voted on patch set 1 V -1 02/29/20, 13:55 Completed build in 21s on Sat, 29 Feb, 01:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-858
-
Christian Eßl uploaded patch set 2 02/29/20, 13:57
-
TYPO3com voted on patch set 2 V +1 02/29/20, 14:07 Completed build in 10m 32s on Sat, 29 Feb, 02:07 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-859
-
Susi Moog commented on patch set 2 CR -1 02/29/20, 18:44
From reading: \TYPO3\CMS\Adminpanel\Modules\DebugModule::getShortInfo needs adjustments, too, to display the correct count of messages - additionally as that was part of the API, please don't do this for 9.5 (I'm not even sure about master, as this is technically breaking, depending on what is logged - for example, I log hook calls with this, where the order is relevant and multiple calls should be logged separately) The CLI part is ok. -
Christian Eßl commented on patch set 2 03/05/20, 18:14
Ok, will abandon this patch and just disable the Logger in cli mode for now -
Christian Eßl abandoned the change 03/05/20, 18:15