63511[BUGFIX] Show scrollbar earlier in pagetree on larger pagetrees
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Georg Ringer +1
-
Verified V +2 Done
- Andreas Kienast +2
- Georg Ringer +1
- Riccardo De Contardi +1
- TYPO3com +1 CI
Issues 2
Files 2
Review log 1320
-
Christian Eßl uploaded patch set 1 02/29/20, 14:51
-
TYPO3com voted on patch set 1 V -1 02/29/20, 15:01 Completed build in 09m 49s on Sat, 29 Feb, 03:01 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-860
-
Christian Eßl uploaded patch set 2 02/29/20, 18:26
-
Christian Eßl updated the commit message in patch set 3 02/29/20, 18:27
-
Christian Eßl updated the commit message in patch set 4 02/29/20, 18:27
-
TYPO3com voted on patch set 2 V +1 02/29/20, 18:41 Completed build in 13m 46s on Sat, 29 Feb, 06:41 PM Test Summary: 72049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-871
-
TYPO3com voted on patch set 3 V -1 02/29/20, 18:46 Completed build in 18m 32s on Sat, 29 Feb, 06:46 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-872
-
TYPO3com voted on patch set 4 V -1 02/29/20, 18:52 Completed build in 24m 52s on Sat, 29 Feb, 06:52 PM Test Summary: 70851 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-873
-
TYPO3com voted on patch set 4 V +1 02/29/20, 19:50 Completed build in 1h 47m 23s on Sat, 29 Feb, 07:50 PM Test Summary: 72049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-873
-
Riccardo De Contardi commented on patch set 4 02/29/20, 21:08
The scrollbar of #typo3-pagetree-tree is still a bit off-screen (about 4px), i.e. the calculated height of the element is still a bit too much; I think that the reason is the height of #svg-toolbar that must have an additional 4px for its padding. I've found it strange because the css should have a border-box reset on everything. I investigated the backend.css and found ``` * { box-sizing: border-box } :after, :before { box-sizing: border-box } ``` which is IMO wrong -
Riccardo De Contardi commented on patch set 4 02/29/20, 22:33
> Patch Set 4: > > The scrollbar of #typo3-pagetree-tree is still a bit off-screen (about 4px), i.e. the calculated height of the element is still a bit too much; I think that the reason is the height of #svg-toolbar that must have an additional 4px for its padding. I've found it strange because the css should have a border-box reset on everything. I investigated the backend.css and found > > ``` > * { > box-sizing: border-box > } > > :after, > :before { > box-sizing: border-box > } > ``` > which is IMO wrong I reply myself: the problem seems not on the CSS box model, but the javascript .height() that does not consider the padding. -
Christian Eßl uploaded patch set 5 03/01/20, 08:24
-
Christian Eßl uploaded patch set 6 03/01/20, 08:25
-
TYPO3com voted on patch set 5 V +1 03/01/20, 08:39 Completed build in 12m 25s on Sun, 1 Mar, 08:39 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-883
-
TYPO3com voted on patch set 6 V +1 03/01/20, 08:45 Completed build in 18m 30s on Sun, 1 Mar, 08:45 AM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-884
-
Riccardo De Contardi commented on patch set 6 V +1 03/01/20, 09:20
tested on Master; works well with multi-line #svg-toolbar, too -
Andreas Kienast voted on patch set 6 V +1 CR +1 03/01/20, 11:25
-
Georg Ringer voted on patch set 6 V +1 CR +1 03/02/20, 05:59
-
Andreas Kienast voted on patch set 6 V +2 CR +2 03/02/20, 07:06
-
Andreas Kienast merged patch set 7 03/02/20, 07:06