Review main Merged

63512[BUGFIX] Do not assign tab items if their content is empty

Christian Eßl CR +2 V +2 Easy +16 −12 updated 03/06/20, 15:01

Commit message

In a TabsContainer, if all the fields of a tab are hidden to the editor
(by disabling them in PageTS), the tab would still become assigned in
the 'items' fluid variable. The empty, but invisible, tab would then
still be considered for determining the active tab in the view. If the
first tab was disabled in this way, the editor would see no active tab
at all.
To prevent this from happening, the tab elements are now never assigned,
if their content is completely empty.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 67

  1. Christian Eßl uploaded patch set 1 02/29/20, 15:08

  2. TYPO3com voted on patch set 1 V +1 02/29/20, 15:18 Completed build in 10m 10s on Sat, 29 Feb, 03:18 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-861

  3. Daniel Goerz voted on patch set 1 CR +1 02/29/20, 19:47

  4. Susi Moog voted on patch set 1 CR +1 02/29/20, 20:20

  5. Benni Mack voted on patch set 1 V +1 CR +1 03/06/20, 14:54

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 03/06/20, 15:01

  7. Daniel Goerz merged patch set 2 03/06/20, 15:01