Review main Merged

63513[BUGFIX] Respect language access limitations in new PageLayoutView

Christian Eßl CR +2 V +2 Easy +9 −5 updated 03/04/20, 12:25

Commit message

If the user has no access to the default language, the new
fluid based PageLayoutView would fail with an error. This patch
implements proper language access limitation.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Goerz +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1013

  1. Christian Eßl uploaded patch set 1 02/29/20, 15:53

  2. TYPO3com voted on patch set 1 V +1 02/29/20, 16:03 Completed build in 10m 06s on Sat, 29 Feb, 04:03 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-862

  3. Claus Due voted on patch set 1 CR +1 03/01/20, 07:56

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 03/01/20, 09:21

  5. Daniel Goerz commented on patch set 1 V -1 03/01/20, 17:07

    Page Module is still broken for editors with restricted language access * content icons are not rendered if access to language 0 is restricted * column edit button is still present for language 0 if access to language 0 is restricted
  6. Daniel Goerz uploaded patch set 2 03/01/20, 17:09

  7. Daniel Goerz updated the commit message in patch set 3 03/01/20, 17:12

  8. Daniel Goerz voted on patch set 3 V +1 CR +1 03/01/20, 17:12

  9. TYPO3com voted on patch set 2 V +1 03/01/20, 17:19 Completed build in 09m 58s on Sun, 1 Mar, 05:19 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-894

  10. TYPO3com voted on patch set 3 V +1 03/01/20, 17:23 Completed build in 11m 31s on Sun, 1 Mar, 05:23 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-895

  11. Oli Bartsch commented on patch set 3 V +1 CR +1 03/01/20, 17:59

    > Patch Set 1: Verified-1 > > Page Module is still broken for editors with restricted language access > > * content icons are not rendered if access to language 0 is restricted > * column edit button is still present for language 0 if access to language 0 is restricted Thanks for pointing out Daniel. I thought this patch would just handle the TypeError exception which the first patchset already did. But I agree, the language restriction behaviour is now the same as in the PageLayoutView.
  12. Benni Mack voted on patch set 3 V +2 CR +2 03/04/20, 12:25

  13. Benni Mack merged patch set 4 03/04/20, 12:25