Review main Merged

63518[BUGFIX] Fix handling of type "comment" in TypoScript Constant Editor

Christian Eßl CR +2 V +2 Easy +5 −5 updated 03/06/20, 18:32

Commit message

According to the documentation, the boolean checkbox for type "comment"
should behave in the following way:
- checked= “”
- not-checked = “#”

The handling of this behaviour was faulty in the TypoScript Constant
Editor. This means, every time the constants were saved without changing
the "comment" checkbox, its value was reversed.
Further information:
https://docs.typo3.org/m/typo3/reference-typoscript/master/en-us/UsingSetting/TheConstantEditor.html

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 57

  1. Christian Eßl uploaded patch set 1 03/01/20, 10:55

  2. TYPO3com voted on patch set 1 V -1 03/01/20, 11:06 Completed build in 10m 21s on Sun, 1 Mar, 11:06 AM Test Summary: 61824 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-887

  3. TYPO3com voted on patch set 1 V +1 03/01/20, 18:36 Completed build in 10m 28s on Sun, 1 Mar, 06:36 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-900

  4. Susi Moog voted on patch set 1 V +1 CR +1 03/06/20, 15:51

  5. Susi Moog commented on patch set 1 03/06/20, 15:55

    tested with: #cat=conf/something/a; type=comment; label=Something something =
  6. Benni Mack voted on patch set 1 V +2 CR +2 03/06/20, 18:32

  7. Benni Mack merged patch set 2 03/06/20, 18:32