Review main Merged

63520[BUGFIX] Take tables_modify in PageLayoutView into account

Oli Bartsch CR +2 V +2 Easy +20 −6 updated 03/03/20, 14:58

Commit message

If a non-admin user currently has no access to modify the `tt_content`
table they still get editing options displayed in the PageLayoutView.
Using these options leads to an infinty load of the FormEngine.

Therefore a new function `hasContentModificationAndAccessPermissions`
is introduced which also takes `tables_modify` into account. This function
is now used in various places in PageLayoutView and replaces the current
check which only validates the users access permission.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 611

  1. Oli Bartsch uploaded patch set 1 03/01/20, 17:29

  2. TYPO3com voted on patch set 1 V +1 03/01/20, 17:39 Completed build in 09m 52s on Sun, 1 Mar, 05:39 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-897

  3. Daniel Goerz updated the commit message in patch set 2 03/01/20, 17:42

  4. TYPO3com voted on patch set 2 V -1 03/01/20, 17:53 Completed build in 10m 32s on Sun, 1 Mar, 05:53 PM Test Summary: 71751 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-898

  5. TYPO3com voted on patch set 2 V +1 03/01/20, 19:03 Completed build in 10m 15s on Sun, 1 Mar, 07:03 PM Test Summary: 72049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-901

  6. Oli Bartsch uploaded patch set 3 03/02/20, 11:22

  7. TYPO3com voted on patch set 3 V -1 03/02/20, 11:33 Completed build in 10m 33s on Mon, 2 Mar, 11:33 AM Test Summary: 72102 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-913

  8. TYPO3com voted on patch set 3 V +1 03/02/20, 13:02 Completed build in 13m 14s on Mon, 2 Mar, 01:02 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-915

  9. Georg Ringer voted on patch set 3 V +1 CR +1 03/02/20, 13:45

  10. Benni Mack voted on patch set 3 V +2 CR +2 03/03/20, 14:58

  11. Benni Mack merged patch set 4 03/03/20, 14:58