Review main Abandoned

63522[BUGFIX] Remove event binding methods from rAF event

Andreas Kienast CR 0 V 0 Easy +18 −15 updated 03/02/20, 07:33

Commit message

This patch makes the implementation of RequestAnimationFrameEvent
independent from the other event handler implementations, as
RequestAnimationFrame behaves different. Registered callbacks are always
bound to the current `window` object. For this reason, the dependency to
the RegularEvent is removed and the methods bindTo() and delegateTo()
are removed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 1113

  1. Andreas Kienast uploaded patch set 1 03/02/20, 07:04

  2. Susi Moog commented on patch set 1 CR -1 03/02/20, 07:15

    update rst please.
  3. Andreas Kienast commented on patch set 1 CR -1 03/02/20, 07:16

    ReST needs adoption as well
  4. Andreas Kienast uploaded patch set 2 03/02/20, 07:18

  5. TYPO3com voted on patch set 1 V +1 03/02/20, 07:19 Completed build in 14m 41s on Mon, 2 Mar, 07:19 AM Test Summary: 72049 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-907

  6. Daniel Siepmann voted on patch set 2 V +1 03/02/20, 07:21

  7. Susi Moog voted on patch set 2 V +1 CR +1 03/02/20, 07:22

  8. Andreas Kienast uploaded patch set 3 03/02/20, 07:25

  9. Daniel Siepmann voted on patch set 3 V +1 CR +1 03/02/20, 07:25

  10. Susi Moog voted on patch set 3 V +1 CR +1 03/02/20, 07:25

  11. TYPO3com voted on patch set 2 V -1 03/02/20, 07:31 Completed build in 12m 56s on Mon, 2 Mar, 07:31 AM Test Summary: 1 of 72535 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-908

  12. Andreas Kienast voted on patch set 3 CR -2 03/02/20, 07:31

  13. Andreas Kienast abandoned the change 03/02/20, 07:33

    This patch makes no sense, sorry for the buzz