Review main Abandoned

63527[BUGFIX] Return empty string instead of exception if no plugin defined

Georg Ringer CR 0 V 0 Easy +1 −4 updated 03/07/20, 21:19

Commit message

If a plugin should be rendered but no actual plugin has been selected,
no exception should be thrown.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 45

  1. Georg Ringer uploaded patch set 1 03/02/20, 15:18

  2. TYPO3com voted on patch set 1 V -1 03/02/20, 15:28 Completed build in 09m 54s on Mon, 2 Mar, 03:28 PM Test Summary: 6 of 72598 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-922

  3. Christian Eßl commented on patch set 1 03/02/20, 18:18

    Wouldn't that hide configuration errors from the user and make it harder to find out, what she did wrong? I would read the value of config.contentobjectexceptionhandler to determine, if an exception should be thrown or a generic error message should be shown + writing the actual error to a log. Like it's already done when a plugin throws an exception.
  4. Alexander Schnitzler commented on patch set 1 03/02/20, 19:57

    > Patch Set 1: > > Wouldn't that hide configuration errors from the user and make it harder to find out, what she did wrong? > I would read the value of config.contentobjectexceptionhandler to determine, if an exception should be thrown or a generic error message should be shown + writing the actual error to a log. Like it's already done when a plugin throws an exception. I second that.
  5. Georg Ringer abandoned the change 03/07/20, 21:19

    no need for change, see issue