63528[TASK] Use label "default" instead of "none" for Space before/after
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Eßl +1
-
Verified V +2 Done
- Benni Mack +2
- Oli Bartsch +1
- Christian Eßl +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 910
-
Georg Ringer uploaded patch set 1 03/02/20, 15:37
-
Georg Ringer commented on patch set 1 03/02/20, 15:38
This change is ready for review. -
TYPO3com voted on patch set 1 V +1 03/02/20, 15:48 Completed build in 10m 22s on Mon, 2 Mar, 03:48 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-923
-
Oli Bartsch commented on patch set 1 03/02/20, 15:56
The label `space_class_none` then could be removed as it's not used anywhere else. -
Oli Bartsch commented on patch set 1 03/02/20, 16:06
> Patch Set 1: > > The label `space_class_none` then could be removed as it's not used anywhere else. On a second thought, we should keep this label as people might already use it in their own TCA. -
Oli Bartsch voted on patch set 1 V +1 CR +1 03/02/20, 16:20
-
Georg Ringer commented on patch set 1 03/02/20, 16:52
as the label is also public API I don't want to do that -
Christian Eßl voted on patch set 1 V +1 CR +1 03/02/20, 18:19
-
Benni Mack voted on patch set 1 V +2 CR +2 03/02/20, 20:30
-
Benni Mack merged patch set 2 03/02/20, 20:30