Review main Merged

63530[TASK] Upgrade phpstan/phpstan to 0.12.13

Alexander Schnitzler CR +2 V +2 Easy +10 −9 updated 03/03/20, 09:00

Commit message

This version of phpstan heavily improves the analysis
performance by using multi threading and caching out
of the box.

Used command:

    composer require phpstan/phpstan:"^0.12.13" --dev

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 69

  1. Alexander Schnitzler uploaded patch set 1 03/02/20, 19:54

  2. Alexander Schnitzler wrote 03/02/20, 19:55

    Topic set to phpstan
  3. TYPO3com voted on patch set 1 V -1 03/02/20, 20:06 Completed build in 11m 21s on Mon, 2 Mar, 08:06 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-928

  4. TYPO3com voted on patch set 1 V +1 03/02/20, 20:40 Completed build in 57m 18s on Mon, 2 Mar, 08:40 PM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-928

  5. Benni Mack commented on patch set 1 CR -1 03/02/20, 21:33

    Please use "require --dev" and also update typo3/sysext/core/composer.json
  6. Alexander Schnitzler uploaded patch set 2 03/03/20, 07:50

  7. TYPO3com voted on patch set 2 V +1 03/03/20, 08:04 Completed build in 13m 52s on Tue, 3 Mar, 08:04 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-933

  8. Benni Mack voted on patch set 2 V +2 CR +2 03/03/20, 09:00

  9. Benni Mack merged patch set 3 03/03/20, 09:00