Review main Merged

63533[BUGFIX] Streamline language pack download URLs

Benni Mack CR +2 V +2 Easy +9 −6 updated 03/19/20, 11:12

Commit message

* t3o has fileadmin/l10n since 2 years (currently it's a redirect).
* new translation server just took the path as previously on t3o

This is now consolidated:
* t3o is replacing fileadmin/ter with fileadmin/l10n (saving t3o some redirects)
* localize is using xliff/

Both changes are in place already on the remote servers so this change
can be used directly.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Oliver Klee +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1822

  1. Benni Mack uploaded patch set 1 03/03/20, 08:07

  2. Thomas Löffler voted on patch set 1 CR +1 03/03/20, 08:13

  3. TYPO3com voted on patch set 1 V +1 03/03/20, 08:18 Completed build in 10m 17s on Tue, 3 Mar, 08:18 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-934

  4. Georg Ringer commented on patch set 1 CR -1 03/03/20, 09:26

    the language pack old in master is replaced if the old url would have been used, see > if ($languagePackBaseUrl === self::OLD_LANGUAGE_PACK_URL || $languagePackBaseUrl === self::OLD_BETA_LANGUAGE_PACK_URL) { > $languagePackBaseUrl = self::LANGUAGE_PACK_URL; > } that replacment would not work anymore. I guess we should just check if the url begins with typo3.org and then use the new url?
  5. Georg Ringer uploaded patch set 2 03/06/20, 20:55

  6. TYPO3com voted on patch set 2 V -1 03/06/20, 21:10 Completed build in 14m 52s on Fri, 6 Mar, 09:10 PM Test Summary: 15 of 72556 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1057

  7. TYPO3com voted on patch set 2 V +1 03/07/20, 11:05 Completed build in 14h 25m 07s on Sat, 7 Mar, 11:05 AM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1057

  8. Benni Mack voted on patch set 2 V +1 CR +1 03/07/20, 12:03

  9. Daniel Goerz commented on patch set 2 03/07/20, 13:33

    LanguagePackService.php:280

    I can download the zip at the old URL but I get a 404 at the new URL, is this intended?
  10. Susi Moog commented on patch set 2 V -1 03/08/20, 07:16

    LanguagePackService.php:280 Reply

    That's because the new one is not located at typo3.org at all, but at extensions.typo3.org: https://extensions.typo3.org/fileadmin/l10n/b/a/backend-l10n/backend-l10n-fr.v9.zip --> if you put the old url into something that displays redirects (postman/insomnia), you see that for the old translation urls, it ultimately redirects to extensions.typo3.org, on the new translation server (localize.) no redirect happens at all, which makes me guess /xliff/ does not currently exist there.
  11. Benni Mack commented on patch set 2 03/08/20, 07:52

    The /xliff/ folder is being created by Georg, as discussed. @spoonerweb should we use `extensions.typo3.org` instead of typo3.org? Took the new path from the ticket.
  12. Georg Ringer commented on patch set 2 03/08/20, 23:26

    @susi sorry forgot the symlink there
  13. Susi Moog commented on patch set 2 03/09/20, 06:28

    @Georg no problem, thanks, the xliff part is working now Now we only need to know extensions.typo3.org vs typo3.org and it's ready :)
  14. Benni Mack commented on patch set 2 03/09/20, 07:53

    @spoonerweb can you clarify?
  15. Thomas Löffler commented on patch set 2 03/09/20, 08:06

    > Patch Set 2: > > The /xliff/ folder is being created by Georg, as discussed. @spoonerweb should we use `extensions.typo3.org` instead of typo3.org? Took the new path from the ticket. Yes. All the translation files are currently synced with extensions.typo3.org. The typo3.org domain is an ancient part where TER and localization files still were in typo3.org.

    LanguagePackService.php:280 Reply Unresolved

    Should go to extensions.typo3.org/fileadmin/l10n/...
  16. Benni Mack commented on patch set 3 03/16/20, 14:22

    Published edit on patch set 2.
  17. TYPO3com voted on patch set 3 V +1 03/16/20, 14:33 Completed build in 11m 38s on Mon, 16 Mar, 02:33 PM Test Summary: 72270 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1377

  18. Georg Ringer voted on patch set 3 V +1 CR +1 03/17/20, 21:40

  19. Susi Moog voted on patch set 3 V +1 CR +1 03/19/20, 09:42

  20. Oliver Klee voted on patch set 3 CR +1 03/19/20, 11:02

  21. Benni Mack voted on patch set 3 V +2 CR +2 03/19/20, 11:12

  22. Benni Mack merged patch set 4 03/19/20, 11:12