Review main Merged

63540[BUGFIX] Remove view button for indefinite source hosts in redirects module

Christian Eßl CR +2 V +2 Easy +6 −4 updated 03/04/20, 17:31

Commit message

The changes made in #88499 removed the support for "default urls".
This left broken view buttons in the redirects module for redirects
with '*' set as source host, where no domain could be determined.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 2

Files 2

Review log 711

  1. Christian Eßl uploaded patch set 1 03/03/20, 19:52

  2. TYPO3com voted on patch set 1 V -1 03/03/20, 20:02 Completed build in 10m 44s on Tue, 3 Mar, 08:02 PM Test Summary: 1 of 72290 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-956

  3. TYPO3com commented on patch set 1 03/03/20, 20:42 Completed build in 11m 44s on Tue, 3 Mar, 08:41 PM Test Summary: 1 of 72598 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-957

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 03/04/20, 07:33

  5. TYPO3com commented on patch set 1 03/04/20, 07:49 Completed build in 11h 30m 52s on Wed, 4 Mar, 07:49 AM Test Summary: 1 of 72598 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-957

  6. Daniel Goerz commented on patch set 1 03/04/20, 07:57

    Ah sorry, thats a test failing for real
  7. Daniel Goerz uploaded patch set 2 03/04/20, 08:20

  8. TYPO3com voted on patch set 2 V +1 03/04/20, 08:52 Completed build in 29m 14s on Wed, 4 Mar, 08:52 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-970

  9. Oli Bartsch voted on patch set 2 V +1 CR +1 03/04/20, 08:55

  10. Daniel Goerz voted on patch set 2 V +2 CR +2 03/04/20, 17:31

  11. Daniel Goerz merged patch set 3 03/04/20, 17:31