Review main Merged

63543[BUGFIX] LinkService should identify urls starting with //

Georg Ringer CR +2 V +2 Easy +8 −2 updated 03/06/20, 21:59

Commit message

Urls starting with `//` should have a proper fallback to
avoid warnings e.g. in InputLinkElement that this type of url
is unknown.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1115

  1. Georg Ringer uploaded patch set 1 03/04/20, 05:15

  2. Georg Ringer commented on patch set 1 03/04/20, 05:15

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 03/04/20, 05:15 Completed build in 21s on Wed, 4 Mar, 05:15 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-959

  4. Georg Ringer uploaded patch set 2 03/04/20, 05:26

  5. TYPO3com voted on patch set 2 V +1 03/04/20, 05:36 Completed build in 10m 13s on Wed, 4 Mar, 05:36 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-960

  6. Christian Eßl commented on patch set 2 03/04/20, 06:39

    UrlLinkHandler.php:59

    What about https: as possible fallback?
  7. Oli Bartsch commented on patch set 2 03/04/20, 07:02

    UrlLinkHandler.php:59 Reply Unresolved

    If I understand it correct, the reason people use the protocol relative directives `//` is that they want to preserve the current protocol no matter if it’s currently http or https. Adding either http or https here for this case is therefore wrong as this makes the reason of using this method obsolet.
  8. Georg Ringer uploaded patch set 3 03/05/20, 13:12

  9. TYPO3com voted on patch set 3 V +1 03/05/20, 13:22 Completed build in 09m 47s on Thu, 5 Mar, 01:22 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-986

  10. Roland Golla commented on patch set 3 V +1 03/06/20, 15:27

    Works good for me
  11. Benni Mack commented on patch set 4 03/06/20, 20:11

    Published edit on patch set 3.
  12. TYPO3com voted on patch set 4 V +1 03/06/20, 20:24 Completed build in 13m 03s on Fri, 6 Mar, 08:24 PM Test Summary: 72072 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1055

  13. Benni Mack voted on patch set 4 V +1 CR +1 03/06/20, 20:34

  14. Daniel Goerz voted on patch set 4 V +2 CR +2 03/06/20, 21:59

  15. Daniel Goerz merged patch set 5 03/06/20, 21:59