Review 9.5 Merged

63545[TASK] Use attribute translate="no" for non translatable strings

Georg Ringer CR +2 V +2 Easy +14 −14 updated 03/04/20, 07:59

Commit message

If a string is used in a XLIFF file but it should not be translated,
it must be identified as such. The XLIFF standard provides the attribute
"translate", see
http://docs.oasis-open.org/xliff/v1.2/os/xliff-core.html#translate.

The big advantage is that translators on Crowdin don't even see those labels anymore.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Susi Moog +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Susi Moog +1

Issues 1

Files 4

Review log 68

  1. Georg Ringer uploaded patch set 1 03/04/20, 07:40

  2. Georg Ringer commented on patch set 1 03/04/20, 07:40

    This change is ready for review.
  3. Georg Ringer updated the commit message in patch set 2 03/04/20, 07:41

  4. Susi Moog voted on patch set 2 V +1 CR +1 03/04/20, 07:44

  5. Georg Ringer voted on patch set 2 V +2 CR +2 03/04/20, 07:48

  6. Georg Ringer merged patch set 3 03/04/20, 07:48

  7. TYPO3com voted on patch set 1 V +1 03/04/20, 07:53 Completed build in 12m 34s on Wed, 4 Mar, 07:53 AM Test Summary: 74370 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-144

  8. TYPO3com voted on patch set 2 V +1 03/04/20, 07:59 Completed build in 13m 45s on Wed, 4 Mar, 07:59 AM Test Summary: 74370 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-145