Review main Merged

63547[BUGFIX] Don't show newLanguageButton if user has no edit permissions

Oli Bartsch CR +2 V +2 Easy +1 −1 updated 03/06/20, 10:36

Commit message

With #90608 the PageLayoutView was extended to also
take `tables_modify` for `tt_content` into account.

Unfortunately the newLanguageButton was forgotten,
which also needs to be checked regarding proper edit permissions,
as without these, translating a `tt_content` record is not possible.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Susi Moog +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 811

  1. Oli Bartsch uploaded patch set 1 03/04/20, 08:18

  2. TYPO3com voted on patch set 1 V +1 03/04/20, 08:49 Completed build in 25m 27s on Wed, 4 Mar, 08:49 AM Test Summary: 72114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-969

  3. Oli Bartsch updated the commit message in patch set 2 03/04/20, 09:19

  4. TYPO3com voted on patch set 2 V +1 03/04/20, 09:32 Completed build in 12m 51s on Wed, 4 Mar, 09:32 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-975

  5. Georg Ringer commented on patch set 2 V +1 CR -1 03/04/20, 09:37

    extended
  6. Oli Bartsch updated the commit message in patch set 3 03/04/20, 09:44

  7. Oli Bartsch commented on patch set 3 03/04/20, 09:44

    Reply

    Done
  8. Georg Ringer voted on patch set 3 V +1 CR +1 03/04/20, 09:53

  9. TYPO3com voted on patch set 3 V +1 03/04/20, 09:55 Completed build in 10m 30s on Wed, 4 Mar, 09:55 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-976

  10. Susi Moog voted on patch set 3 V +2 CR +2 03/06/20, 10:36

  11. Susi Moog merged patch set 4 03/06/20, 10:36