Review main Merged

63548[BUGFIX] Re-enable Guzzle versions > 6.5.0

Benni Mack CR +2 V +2 Easy +3 −3 updated 03/06/20, 08:27

Commit message

Guzzle 6.5.0 introduced an issue with umlaut domains
which was fixed in Guzzle 6.5.1 and Guzzle 6.5.2
respectively.

The conflict section in composer.json is now
updated, in order to allow composer-based TYPO3
installations to
a) allow TYPO3 updates to 10.3.x/9.5.14/8.7.31 even
if guzzle has been locked in composer.lock to 6.5.2 already
b) allow to use the latest Guzzle fixes again

Used composer command:
  composer update --lock

See https://github.com/guzzle/guzzle/issues/2448 which
was integrated in Guzzle 6.5.1 (which was released AFTER
our core release in December 2019)

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1116

  1. Benni Mack uploaded patch set 1 03/04/20, 09:04

  2. Benni Mack updated the commit message in patch set 2 03/04/20, 09:07

  3. Susi Moog voted on patch set 2 CR +1 03/04/20, 09:10

  4. Georg Ringer uploaded patch set 3 03/04/20, 09:12

  5. Georg Ringer voted on patch set 3 V +1 CR +1 03/04/20, 09:12

  6. TYPO3com voted on patch set 1 V +1 03/04/20, 09:17 Completed build in 12m 17s on Wed, 4 Mar, 09:17 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-972

  7. TYPO3com voted on patch set 2 V +1 03/04/20, 09:22 Completed build in 14m 42s on Wed, 4 Mar, 09:22 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-973

  8. TYPO3com voted on patch set 3 V -1 03/04/20, 09:25 Completed build in 12m 59s on Wed, 4 Mar, 09:25 AM Test Summary: 1 of 72604 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-974

  9. TYPO3com voted on patch set 3 V +1 03/04/20, 12:51 Completed build in 3h 52m 21s on Wed, 4 Mar, 12:51 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-974

  10. Benni Mack voted on patch set 3 CR -2 03/04/20, 15:05

  11. Benni Mack uploaded patch set 4 03/06/20, 07:39

  12. Benni Mack voted on patch set 4 CR 0 03/06/20, 07:41

  13. Andreas Kienast voted on patch set 4 CR +1 03/06/20, 07:42

  14. TYPO3com voted on patch set 4 V +1 03/06/20, 07:51 Completed build in 11m 50s on Fri, 6 Mar, 07:51 AM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1005

  15. Benni Mack voted on patch set 4 V +2 CR +2 03/06/20, 08:27

  16. Benni Mack merged patch set 5 03/06/20, 08:27