Review main Merged

63549[BUGFIX] Remove sys_file_metadata width and height from excludefields

Georg Ringer CR +2 V +2 Easy +0 −2 updated 03/04/20, 15:04

Commit message

This is a followup to #81964 which removed the exclude configuration
from the fields width & height.
However, if EXT:filemetadata is installed, this overrides the TCA again.
This patch removes the information there as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Froemken +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Froemken +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 89

  1. Georg Ringer uploaded patch set 1 03/04/20, 12:05

  2. Georg Ringer commented on patch set 1 03/04/20, 12:05

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V +1 03/04/20, 12:15 Completed build in 10m 14s on Wed, 4 Mar, 12:15 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-977

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 03/04/20, 12:59

  5. Stefan Froemken commented on patch set 1 V +1 CR +1 03/04/20, 14:49

    Unresolved

    Nitpicking: Years ago I remember that commit messages must contain present tense only. Don't know, if this is still valid.
  6. Georg Ringer commented on patch set 1 03/04/20, 14:51

    But the mentioned patch happened in the past...
  7. Benni Mack commented on patch set 1 V -1 03/04/20, 15:03

    I like the ping pong here... https://review.typo3.org/c/Packages/TYPO3.CMS/+/59883 We can then re-open the other ticket again?...
  8. Benni Mack voted on patch set 1 V +2 CR +2 03/04/20, 15:04

  9. Benni Mack merged patch set 2 03/04/20, 15:04