Review main Merged

63550[TASK] Lower priority of Argon2id

Gerrit Mohrmann CR +2 V +2 Easy +1 −1 updated 03/06/20, 13:26

Commit message

Argon2id should never be set automatically for compatibility reasons.

At some places the array sorting will give the priority which password
hashing type will be used, but the priority value from the preset is
also used.

To make sure Argon2i is set for new installations, priority of Argon2id
is set below Argon2i.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Benni Mack +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 56

  1. Gerrit Mohrmann uploaded patch set 1 03/04/20, 21:10

  2. TYPO3com voted on patch set 1 V +1 03/04/20, 21:21 Completed build in 10m 32s on Wed, 4 Mar, 09:21 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-980

  3. Susi Moog commented on patch set 1 03/06/20, 10:18

    I'm not sure about this one tbh. If argon2id is available it is probably the most secure password hashing variant. I agree that it should be consistent, however the compat problems should be similar between argon2i and argon2id.
  4. Benni Mack voted on patch set 1 V +1 CR +1 03/06/20, 12:59

  5. Frank Nägler voted on patch set 1 V +2 CR +2 03/06/20, 13:26

  6. Frank Nägler merged patch set 2 03/06/20, 13:26