Review main Merged

63552[BUGFIX] Require codeception/lib-asserts:^1.1

Anja Leichsenring CR +2 V +2 Easy +2 −1 updated 03/05/20, 12:36

Commit message

The version contains a bugfix, that caused acceptance test to fail
due to missing method declaration.
Using ^1.1 as minimum requirement prevents acceptance tests from failing
with usage of low codeception packages after codeception version 4 release.

composer require codeception/lib-asserts:^1.1 --dev

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 79

  1. Anja Leichsenring uploaded patch set 1 03/05/20, 12:00

  2. Anja Leichsenring updated the commit message in patch set 2 03/05/20, 12:01

  3. Anja Leichsenring commented on patch set 2 03/05/20, 12:09

    triggered a nightly to check on the results: https://bamboo.typo3.com/browse/CORE-GTN-25
  4. TYPO3com voted on patch set 2 V -1 03/05/20, 12:13 Completed build in 11m 43s on Thu, 5 Mar, 12:13 PM Test Summary: 2 of 72604 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-985

  5. TYPO3com voted on patch set 2 V +1 03/05/20, 12:19 Completed build in 29m 28s on Thu, 5 Mar, 12:19 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-985

  6. Georg Ringer voted on patch set 2 CR +1 03/05/20, 12:22

  7. Georg Ringer voted on patch set 2 V +1 03/05/20, 12:26

  8. Andreas Kienast voted on patch set 2 V +2 CR +2 03/05/20, 12:36

  9. Andreas Kienast merged patch set 3 03/05/20, 12:36