Review main Merged

63555[TASK] Disable InMemoryLogWriter in CLI mode

Christian Eßl CR +2 V +2 Easy +4 −1 updated 03/07/20, 11:15

Commit message

Do not register InMemoryLogWriter in cli mode, as it is not needed here
or used later in any way, and will just fill up the memory and slow down
the script execution, if many log messages are written to it.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1215

  1. Christian Eßl uploaded patch set 1 03/05/20, 18:19

  2. TYPO3com voted on patch set 1 V +1 03/05/20, 18:30 Completed build in 11m 01s on Thu, 5 Mar, 06:30 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-994

  3. Georg Ringer commented on patch set 1 03/05/20, 19:06

    ext_localconf.php:64

    what about using TYPO3_MODE === 'FE', I guess this is also not needed in BE?
  4. Benni Mack commented on patch set 1 CR -1 03/06/20, 20:58

    ext_localconf.php:64 Reply

    LOL. we have Environment::isCli() :)
  5. Benni Mack commented on patch set 1 03/06/20, 20:58

    ext_localconf.php:63

    we also should add a comment to disable it.
  6. Christian Eßl rebased onto patch set 2 03/06/20, 21:05

  7. Christian Eßl uploaded patch set 3 03/06/20, 21:06

  8. Christian Eßl commented on patch set 3 03/06/20, 21:07

    ext_localconf.php:63 Reply

    Done

    ext_localconf.php:64 Reply

    Done
  9. Benni Mack voted on patch set 3 CR +1 03/06/20, 21:13

  10. TYPO3com voted on patch set 2 V +1 03/06/20, 21:19 Completed build in 13m 47s on Fri, 6 Mar, 09:19 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1059

  11. TYPO3com voted on patch set 3 V +1 03/06/20, 21:23 Completed build in 13m 38s on Fri, 6 Mar, 09:23 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1060

  12. Susi Moog voted on patch set 3 V +1 CR +1 03/07/20, 09:39

  13. Benni Mack voted on patch set 3 V +2 CR +2 03/07/20, 11:14

  14. Benni Mack merged patch set 4 03/07/20, 11:14

  15. Benni Mack commented on patch set 4 03/07/20, 11:15

    Just for the sake of completeness - I really *hate* if conditions in ext_localconf.php (makes running subrequests in the same process impossible). but i see no other way around for now here.