63555[TASK] Disable InMemoryLogWriter in CLI mode
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1215
-
Christian Eßl uploaded patch set 1 03/05/20, 18:19
-
TYPO3com voted on patch set 1 V +1 03/05/20, 18:30 Completed build in 11m 01s on Thu, 5 Mar, 06:30 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-994
-
Georg Ringer commented on patch set 1 03/05/20, 19:06
-
Benni Mack commented on patch set 1 CR -1 03/06/20, 20:58
ext_localconf.php:64ReplyLOL. we have Environment::isCli() :) -
Benni Mack commented on patch set 1 03/06/20, 20:58
ext_localconf.php:63we also should add a comment to disable it. -
Christian Eßl rebased onto patch set 2 03/06/20, 21:05
-
Christian Eßl uploaded patch set 3 03/06/20, 21:06
-
Christian Eßl commented on patch set 3 03/06/20, 21:07
ext_localconf.php:63ReplyDoneext_localconf.php:64ReplyDone -
Benni Mack voted on patch set 3 CR +1 03/06/20, 21:13
-
TYPO3com voted on patch set 2 V +1 03/06/20, 21:19 Completed build in 13m 47s on Fri, 6 Mar, 09:19 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1059
-
TYPO3com voted on patch set 3 V +1 03/06/20, 21:23 Completed build in 13m 38s on Fri, 6 Mar, 09:23 PM Test Summary: 72093 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1060
-
Susi Moog voted on patch set 3 V +1 CR +1 03/07/20, 09:39
-
Benni Mack voted on patch set 3 V +2 CR +2 03/07/20, 11:14
-
Benni Mack merged patch set 4 03/07/20, 11:14
-
Benni Mack commented on patch set 4 03/07/20, 11:15
Just for the sake of completeness - I really *hate* if conditions in ext_localconf.php (makes running subrequests in the same process impossible). but i see no other way around for now here.
ext_localconf.php:64