Review main Merged

63556[BUGFIX] Provide return value for SendEmailCommand

Anja Leichsenring CR +2 V +2 Easy +5 −3 updated 03/05/20, 20:57

Commit message

The parent class defines a return value of type int, but the command
does not provide one. This causes a test failure after latest dependency
update of codeception version 4.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 811

  1. Anja Leichsenring uploaded patch set 1 03/05/20, 19:23

  2. TYPO3com voted on patch set 1 V -1 03/05/20, 19:23 Completed build in 21s on Thu, 5 Mar, 07:23 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-995

  3. Georg Ringer commented on patch set 1 CR -1 03/05/20, 19:32

    can we please fix all of those in one go? e.g. extension activate and so on all miss the return value
  4. Anja Leichsenring uploaded patch set 2 03/05/20, 19:33

  5. Anja Leichsenring commented on patch set 2 03/05/20, 19:36

    yes, sure, as much as I can catch.
  6. TYPO3com voted on patch set 2 V -1 03/05/20, 19:43 Completed build in 10m 22s on Thu, 5 Mar, 07:43 PM Test Summary: 71828 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-996

  7. TYPO3com voted on patch set 2 V +1 03/05/20, 19:50 Completed build in 27m 35s on Thu, 5 Mar, 07:50 PM Test Summary: 72120 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-996

  8. Richard Haeser voted on patch set 2 V +1 CR +1 03/05/20, 19:51

  9. Anja Leichsenring commented on patch set 2 03/05/20, 20:44

    additional, not test breaking commands are handled here: https://review.typo3.org/c/Packages/TYPO3.CMS/+/63557
  10. Georg Ringer voted on patch set 2 V +2 CR +2 03/05/20, 20:57

  11. Georg Ringer merged patch set 3 03/05/20, 20:57