Review main Merged

63557[TASK] Let all Commands return an int value

Anja Leichsenring CR +2 V +2 Easy +40 −3 updated 03/06/20, 12:29

Commit message

The parent class states an integer value is returned,
but most core commands did not follow that rule. Now they
got according return statements to fulfill that contract.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Georg Ringer +1
    • TYPO3com +1 CI

Issues 1

Files 21

Show 1 more file

Review log 1013

  1. Anja Leichsenring uploaded patch set 1 03/05/20, 20:00

  2. Georg Ringer voted on patch set 1 V +1 CR +1 03/05/20, 20:08

  3. TYPO3com voted on patch set 1 V -1 03/05/20, 20:11 Completed build in 10m 56s on Thu, 5 Mar, 08:11 PM Test Summary: 3 of 70623 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-997

  4. Anja Leichsenring uploaded patch set 2 03/05/20, 20:32

  5. TYPO3com voted on patch set 2 V -1 03/05/20, 20:43 Completed build in 10m 49s on Thu, 5 Mar, 08:43 PM Test Summary: 1 of 71846 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-998

  6. TYPO3com voted on patch set 2 V +1 03/05/20, 20:47 Completed build in 25m 37s on Thu, 5 Mar, 08:47 PM Test Summary: 72118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-998

  7. Georg Ringer voted on patch set 2 V +1 CR +1 03/05/20, 20:57

  8. Benni Mack commented on patch set 2 03/06/20, 09:16

    Isn't this a "Bugfix" in order to make our commands compatible with Symfony5?
  9. Daniel Goerz commented on patch set 2 03/06/20, 09:29

    > Patch Set 2: > > Isn't this a "Bugfix" in order to make our commands compatible with Symfony5? I am fine with BUGFIX as well as with TASK, the question is whether we backport to 9?
  10. Susi Moog commented on patch set 2 03/06/20, 10:14

    > Patch Set 2: > > > Patch Set 2: > > > > Isn't this a "Bugfix" in order to make our commands compatible with Symfony5? > > I am fine with BUGFIX as well as with TASK, the question is whether we backport to 9? v9 doesn't allow usage of symfony 5 for console currently - so it's technically not necessary
  11. Benni Mack commented on patch set 2 03/06/20, 11:02

    OK. master only
  12. Frank Nägler voted on patch set 2 V +2 CR +2 03/06/20, 12:29

  13. Frank Nägler merged patch set 3 03/06/20, 12:29