63557[TASK] Let all Commands return an int value
Commit message
Review
-
Code review CR +2 Done
- Frank Nägler +2
- Georg Ringer +1
-
Verified V +2 Done
- Frank Nägler +2
- Georg Ringer +1
- TYPO3com +1 CI
Issues 1
Files 21
- typo3/sysext/backend/Classes/Command/LockBackendCommand.php+2 −0
- typo3/sysext/backend/Classes/Command/ReferenceIndexUpdateCommand.php+2 −0
- typo3/sysext/backend/Classes/Command/UnlockBackendCommand.php+4 −2
- typo3/sysext/core/Classes/Command/DumpAutoloadCommand.php+1 −0
- typo3/sysext/core/Classes/Command/ExtensionListCommand.php+1 −0
- typo3/sysext/core/Classes/Command/SiteShowCommand.php+1 −0
- typo3/sysext/extensionmanager/Classes/Command/ActivateExtensionCommand.php+1 −0
- typo3/sysext/extensionmanager/Classes/Command/DeactivateExtensionCommand.php+1 −0
- typo3/sysext/impexp/Classes/Command/ImportCommand.php+2 −0
- typo3/sysext/lowlevel/Classes/Command/CleanFlexFormsCommand.php+2 −0
- typo3/sysext/lowlevel/Classes/Command/DeletedRecordsCommand.php+2 −0
- typo3/sysext/lowlevel/Classes/Command/FilesWithMultipleReferencesCommand.php+2 −0
- typo3/sysext/lowlevel/Classes/Command/ListSysLogCommand.php+2 −0
- typo3/sysext/lowlevel/Classes/Command/LostFilesCommand.php+2 −0
- typo3/sysext/lowlevel/Classes/Command/MissingFilesCommand.php+2 −0
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php+2 −0
- typo3/sysext/lowlevel/Classes/Command/OrphanRecordsCommand.php+2 −0
- typo3/sysext/redirects/Classes/Command/CheckIntegrityCommand.php+3 −1
- typo3/sysext/workspaces/Classes/Command/AutoPublishCommand.php+2 −0
- typo3/sysext/workspaces/Classes/Command/CleanupPreviewLinksCommand.php+2 −0
Review log 1013
-
Anja Leichsenring uploaded patch set 1 03/05/20, 20:00
-
Georg Ringer voted on patch set 1 V +1 CR +1 03/05/20, 20:08
-
TYPO3com voted on patch set 1 V -1 03/05/20, 20:11 Completed build in 10m 56s on Thu, 5 Mar, 08:11 PM Test Summary: 3 of 70623 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-997
-
Anja Leichsenring uploaded patch set 2 03/05/20, 20:32
-
TYPO3com voted on patch set 2 V -1 03/05/20, 20:43 Completed build in 10m 49s on Thu, 5 Mar, 08:43 PM Test Summary: 1 of 71846 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-998
-
TYPO3com voted on patch set 2 V +1 03/05/20, 20:47 Completed build in 25m 37s on Thu, 5 Mar, 08:47 PM Test Summary: 72118 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-998
-
Georg Ringer voted on patch set 2 V +1 CR +1 03/05/20, 20:57
-
Benni Mack commented on patch set 2 03/06/20, 09:16
Isn't this a "Bugfix" in order to make our commands compatible with Symfony5? -
Daniel Goerz commented on patch set 2 03/06/20, 09:29
> Patch Set 2: > > Isn't this a "Bugfix" in order to make our commands compatible with Symfony5? I am fine with BUGFIX as well as with TASK, the question is whether we backport to 9? -
Susi Moog commented on patch set 2 03/06/20, 10:14
> Patch Set 2: > > > Patch Set 2: > > > > Isn't this a "Bugfix" in order to make our commands compatible with Symfony5? > > I am fine with BUGFIX as well as with TASK, the question is whether we backport to 9? v9 doesn't allow usage of symfony 5 for console currently - so it's technically not necessary -
Benni Mack commented on patch set 2 03/06/20, 11:02
OK. master only -
Frank Nägler voted on patch set 2 V +2 CR +2 03/06/20, 12:29
-
Frank Nägler merged patch set 3 03/06/20, 12:29