Review main Abandoned

63558[BUGFIX] Throw exceptions instead of 404 errors with no hint

Georg Ringer CR 0 V 0 Easy +11 −15 updated 10/07/22, 10:45

Commit message

The Install Tool just returns a 404 if the LocalConfiguration.php file
is not available or if the Install Tool password is not set.

To make debugging easier, exceptions are now thrown instead.
The setting SYS[displayErrors] is respected at this time
to avoid any possible security issues.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1013

  1. Georg Ringer uploaded patch set 1 03/05/20, 22:38

  2. Georg Ringer commented on patch set 1 03/05/20, 22:38

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 03/05/20, 22:48 Completed build in 09m 52s on Thu, 5 Mar, 10:48 PM Test Summary: 3 of 72604 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1000

  4. Oli Bartsch rebased onto patch set 2 03/06/20, 06:20

  5. Oli Bartsch uploaded patch set 3 03/06/20, 06:22

  6. TYPO3com voted on patch set 2 V -1 03/06/20, 06:30 Completed build in 10m 22s on Fri, 6 Mar, 06:30 AM Test Summary: 3 of 72604 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1001

  7. TYPO3com voted on patch set 3 V -1 03/06/20, 06:35 Completed build in 12m 56s on Fri, 6 Mar, 06:35 AM Test Summary: 3 of 72604 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1002

  8. Oli Bartsch commented on patch set 3 03/06/20, 06:40

    Fixed a missing negation which breaks the whole install tool in BE but the test still fail.
  9. Oli Bartsch commented on patch set 3 V -1 03/06/20, 07:27

    Problem here is that the middleware is also used for the first install where the requirements are different. No LocalConfiguration and FIRST_INSTALL file required. This behaviour breaks by throwing the Exceptions, because in this case the information about how to create FIRST_INSTALL should be shown. So it's fine if everything is FALSE in this scenario. On the other side in the Install Tool (after the first installation) the same scenario should trigger the Exceptions. So without any evidence in which context we are currently, I see no possibility to throw exceptions here as this would break the first install. Bit more detailed: Scenario 1 (First install): No FIRST_INSTALL, No LocalConfiguration -> Fine, shows "create FIRST_INSTALL" Scenario 2 (First install): FIRST_INSTALL file created, No LocalConfiguration -> Fine, starts the install Scenario 3 (Install tool): No FIRST_INSTALL, No LocalConfiguration -> Error as LocalConfiguration is required Scenario 4 (Install tool): FIRST_INSTALL file created, No LocalConfiguration -> (current behaviour) Fine, starts the install Please correct me if I misunderstood something, but many different approaches failed in at least one scenario.
  10. Roland Golla commented on patch set 3 V +1 03/06/20, 14:57

    On installed page exception throw works for me (1/1) #1583447515 RuntimeException The configuration ['BE']['installToolPassword'] must be set!
  11. Georg Ringer abandoned the change 04/07/20, 03:02

    abandoned as not easy to fix
  12. Stephan Großberndt commented on patch set 3 10/07/22, 10:05

    I just spent a lot of time debugging the TYPO3 Middleware stack, server configuration and lots of other places trying to find out why in the TYPO3 backend all admin tools except "Extensions" only show a blank page and /typo3/install.php as well. I think it is very unfortunate the very simple piece of information "install tool password is empty" is not delivered to the user.
  13. Markus Klein commented on patch set 3 10/07/22, 10:45

    Reply Unresolved

    I did the same twice already in instances.